Closed
Bug 798685
Opened 12 years ago
Closed 12 years ago
Port |Bug 794602 - nsWebBrowserPersist::SaveURIInternal creates a channel out of thin air| to SeaMonkey
Categories
(SeaMonkey :: MailNews: Backend, defect)
SeaMonkey
MailNews: Backend
Tracking
(seamonkey2.15 fixed)
RESOLVED
FIXED
seamonkey2.15
Tracking | Status | |
---|---|---|
seamonkey2.15 | --- | fixed |
People
(Reporter: ewong, Assigned: ewong)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #797524 +++
c++ -o nsMessenger.o -c -I../../../mozilla/dist/stl_wrappers -I../../../mozilla/dist/system_wrappers -include /sources/comm-central/mozilla/config/gcc_hidden.h -DMOZ_LDAP_XPCOM -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"Linux3.6\" -DOSARCH=Linux -DHAVE_MOVEMAIL -I/sources/comm-central/mailnews/base/src -I. -I../../../mozilla/dist/include -I../../../mozilla/dist/include/nsprpub `/home/ojab/opt/mail/mozilla/dist/sdk/bin/nspr-config --prefix=/home/ojab/opt/mail/mozilla/dist --includedir=/home/ojab/opt/mail/mozilla/dist/include/nspr --cflags` -I/home/ojab/opt/mail/mozilla/dist/include/nss -fPIC -pedantic -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wno-ctor-dtor-privacy -Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros -Wcast-align -Wno-long-long -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -g -Os -freorder-blocks -fomit-frame-pointer -DMOZILLA_CLIENT -include ../../../comm-config.h -MD -MF .deps/nsMessenger.pp /sources/comm-central/mailnews/base/src/nsMessenger.cpp
/sources/comm-central/mailnews/base/src/nsMessenger.cpp: In member function ‘nsresult nsSaveMsgListener::InitializeDownload(nsIRequest*, uint32_t)’:
/sources/comm-central/mailnews/base/src/nsMessenger.cpp:1726:57: error: no matching function for call to ‘nsITransfer::Init(nsCOMPtr<nsIURI>&, nsCOMPtr<nsIURI>&, const nsAFlatString&, nsCOMPtr<nsIMIMEInfo>&, PRTime&, NULL, nsSaveMsgListener* const)’
/sources/comm-central/mailnews/base/src/nsMessenger.cpp:1726:57: note: candidate is:
In file included from /sources/comm-central/mailnews/base/src/nsMessenger.cpp:102:0:
../../../mozilla/dist/include/nsITransfer.h:39:14: note: virtual nsresult nsITransfer::Init(nsIURI*, nsIURI*, const nsAString_internal&, nsIMIMEInfo*, PRTime, nsIFile*, nsICancelable*, bool)
../../../mozilla/dist/include/nsITransfer.h:39:14: note: candidate expects 8 arguments, 7 provided
make[8]: *** [nsMessenger.o] Error 1
make[8]: Leaving directory `/home/ojab/opt/mail/mailnews/base/src'
make[7]: *** [src_libs] Error 2
Assignee | ||
Updated•12 years ago
|
Summary: SeaMonkey build is broken after Bug 795065 (error: no matching function for call to ‘nsITransfer::Init…) → SeaMonkey build is broken after Bug 794602 (nsWebBrowserPersist::SaveURIInternal creates a channel out of thin air)
Assignee | ||
Comment 1•12 years ago
|
||
Since SeaMonkey doesn't have Private Browsing, setting final parameter to 'null'. This parameter should be set to the appropriate value when Private Browsing is added to SeaMonkey.
Attachment #668718 -
Flags: review?(neil)
Assignee | ||
Updated•12 years ago
|
Attachment #668718 -
Attachment is obsolete: true
Attachment #668718 -
Flags: review?(neil)
Assignee | ||
Updated•12 years ago
|
Summary: SeaMonkey build is broken after Bug 794602 (nsWebBrowserPersist::SaveURIInternal creates a channel out of thin air) → Port Bug 794602 (nsWebBrowserPersist::SaveURIInternal creates a channel out of thin air)
Assignee | ||
Updated•12 years ago
|
Summary: Port Bug 794602 (nsWebBrowserPersist::SaveURIInternal creates a channel out of thin air) → Port |Bug 794602 - nsWebBrowserPersist::SaveURIInternal creates a channel out of thin air| to SeaMonkey
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #668726 -
Flags: review?(neil)
Comment 3•12 years ago
|
||
Comment on attachment 668726 [details] [diff] [review]
Add new parameter to saveURI (v1)
The new argument to saveURI is a nsILoadContext, not a boolean.
Attachment #668726 -
Flags: review?(neil) → review-
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #668726 -
Attachment is obsolete: true
Attachment #669049 -
Flags: review?(neil)
Comment 5•12 years ago
|
||
Comment on attachment 669049 [details] [diff] [review]
Add new parameter to saveURI (v2)
Uploading to ftp.m.o now results in a read-only error instead of nothing ;-)
Attachment #669049 -
Flags: review?(neil) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/876f51d9458f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
Settings flags to make tracking of fixed bugs easier.
status-seamonkey2.15:
--- → fixed
Target Milestone: --- → seamonkey2.15
You need to log in
before you can comment on or make changes to this bug.
Description
•