Changes since the last update: #2169 Update zh-TW Translation #2173 Fixes function declaration for strict mode #2167 Tune whitespace insertion #2180 Prevents key handling when the input/toolbar controls are focused #2182 Removed en-US from link to stable version in Readme #2179 Fixes private browsing history #2186 Bug 796584 - Don't use localStorage in pdf.js #2193 Change how we get the resource principal. #2195 Removes usage of print as log #2168 Find bar #2192 Fix the first run code and make it possible to run multiple times. #2196 Fixes console log methods for IE9 #2199 Minor CSS fixed for find bar #2200 Update zh-TW find panel translation #2198 Bug 792582 - Explicitly set privacy status of channels created by pdf.js #2197 Add support for firefox integrated find. #2202 Fixes minor find bugs. #2205 Handle ctrl/cmd+g for html findbar. #2060 Add firefox mouse scrolling support in fullscreen mode. #2208 Add pilot find next/prev icons; localization #2211 Escape key closes findbar #2220 Fixes font debugger; text builder api refactoring #2223 Fixes order in which divs are added to the text layer #2224 Fixes Viewport rotation above 360 #2210 Adds more presentation mode controls #2206 Converted the first and last page buttons to context menu items #2225 Renewed the Dutch translations and added all missing strings #2226 Improved the Dutch and English strings for the first and last page context menu items #2227 Delay extracting text until first find event. #2228 Rounding page div width and height... #2217 Hides cursor in presentation mode #2231 Only use the integrated find if we aren't in an frame. #2238 Bump the version number to 0.6.

Green on Try. https://tbpl.mozilla.org/?tree=Try&rev=1ecbebd1ce84

Comment on attachment 671076 [details] [diff] [review] Update pdf.js to version 0.6.2 Review of attachment 671076 [details] [diff] [review]: ----------------------------------------------------------------- Only a few minor things here but I'd like to see follow-up before it lands. ::: browser/extensions/pdfjs/components/PdfStreamConverter.js @@ +468,5 @@ > + > +FindEventManager.prototype.bind = function() { > + this.contentWindow.addEventListener('unload', function unload(e) { > + this.unbind(); > + this.contentWindow.removeEventListener(e.type, unload); You're not removing the same event listener here as the one added is that returned by bind(). I don't think this will leak as the content window is going away at this point anyway but either correct it or just remove this useless call. @@ +471,5 @@ > + this.unbind(); > + this.contentWindow.removeEventListener(e.type, unload); > + }.bind(this)); > + > + for (var i = 0, ii = this.types.length; i < ii; ++i) { The confusing variable names is ... confusing. Please just use this.types.length, it's cheap enough to not optimise it unnecessarily. @@ +497,5 @@ > + } > +}; > + > +FindEventManager.prototype.unbind = function() { > + for (var i = 0, ii = this.types.length; i < ii; ++i) { As above @@ +619,5 @@ > + var chromeWindow = getChromeWindow(domWindow); > + var findEventManager = new FindEventManager(chromeWindow.gFindBar, > + domWindow, > + chromeWindow); > + findEventManager.bind(); Is there any point in doing this if supportsIntegratedFind is false? ::: browser/extensions/pdfjs/content/PdfJs.jsm @@ +118,5 @@ > + // Make pdf.js the default pdf viewer on the first migration. > + if (currentVersion < 2) { > + this._becomeHandler(); > + } > + Services.prefs.setIntPref(PREF_MIGRATION_VERSION, VERSION); This is going to re-set pdf.js as the default handler even for users who have turned that off in the past right?

Updated to 0.6.39. Changes: #2241 Update l10n/ja/viewer.properties #2252 Removes 'visiblePages[0] is undefined' error #2239 Stops font processing when valid glyphs are absent in the font #2213 Removes PutBinaryImageData compatibility check (re:bug 762657) #2254 Fixes font processing when no glyphs are found #2233 Fixes fit-page and fullscreen #2214 Adds Type1 sbw command support for horizontal fonts #2215 Falls back to ErrorFont when font object is not available or corrupted #2256 Increase wait timeout for api unit tests. #2257 More descriptive link types warning #2240 Fixes text clipping #2258 Addresses review feedback from mc bug 801280. #2244 Fixes cmap when 0xFFFF character is included #2243 Removes useless font tables for PDF rendering #2262 Support 'GoToR'-type links #2245 Fixes reading CFF with two .notdef in charset

(In reply to Dave Townsend (:Mossop) from comment #3) > This is going to re-set pdf.js as the default handler even for users who > have turned that off in the past right? Correct, we wanted to reset this since pdf.js went to the beta version but was disabled.

https://hg.mozilla.org/mozilla-central/rev/af98d67916ad Brendan, I'm assuming you'll handle the aurora uplift nomination.

https://hg.mozilla.org/mozilla-central/rev/af98d67916ad removed the mlp2 headers done by Gervase Markham: http://hg.mozilla.org/mozilla-central/rev/74a06c56da4e

Tim: thanks for spotting that. That is a little unfortunate. I've opened bug 806329 to get this fixed. Gerv