Comment on attachment 671104 [details] [diff] [review] Patch (v1) Review of attachment 671104 [details] [diff] [review]: ----------------------------------------------------------------- Moving review to ekr, who wrote this code. If these are truly unused, fine, remove them, but I suspect they might be there to support features we haven't implemented yet. If so, we can add something to quiet compiler warnings for now. Ekr?

Comment on attachment 671104 [details] [diff] [review] Patch (v1) Review of attachment 671104 [details] [diff] [review]: ----------------------------------------------------------------- offerer_ is definitely going to be needed. components_ I am less sure about, but I suspect we are going to want it to mirror state in this wrapper code.

Can you provide the compiler warnings?

(In reply to comment #3) > Can you provide the compiler warnings? They're unused-private-field clang warnings. These members are indeed unused now. If we're planning to use them later, maybe we can mark them as protected to silence the warnings?

Comment on attachment 671104 [details] [diff] [review] Patch (v1) Clearing the review request as there doesn't seem to be any interest in this patch. :(

The warnings got resolved in bug 825105, leaving the params to support future functionality. Ehsan: sorry this didn't get resolved the first time around.