clang 3.2. warns: media/mtransport/nricectx.h:180:8 [-Wunused-private-field] private field 'offerer_' is not used media/mtransport/nricemediastream.h:113:13 [-Wunused-private-field] private field 'components_' is not used media/mtransport/test/runnable_utils_unittest.cpp:48:52 [-Wextra-semi] extra ';' inside a class media/mtransport/test/sctp_unittest.cpp:265:22 [-Wunused-private-field] private field 'peer_' is not used media/mtransport/test/sctp_unittest.cpp:269:8 [-Wunused-private-field] private field 'gathering_complete_' is not used media/mtransport/test/sctp_unittest.cpp:271:10 [-Wunused-private-field] private field 'to_send_' is not used

This patch fixes the warnings.

Comment on attachment 696186 [details] [diff] [review] Fix five clang warnings in media/mtransport/. Review of attachment 696186 [details] [diff] [review]: ----------------------------------------------------------------- Ponging review to ekr, who wrote this code. It's possible some of these unused params are intended for future updates and we want to keep the API unchanged. Also, this is an imported module, so there may be issues there.

Comment on attachment 696186 [details] [diff] [review] Fix five clang warnings in media/mtransport/. Review of attachment 696186 [details] [diff] [review]: ----------------------------------------------------------------- The unused params in nricectx* are intended for future use. The other changes are fine/

> The unused params in nricectx* are intended for future use. I'll reinstate them, add a |(void)foo;| usage to quell the warning, and add a short comment about the future usage.

Updated version.

ekr: review ping. This is a trivial patch.

Some of the warnings were fixed in the meantime. The landed patch fixes the two remaining ones. https://hg.mozilla.org/integration/mozilla-inbound/rev/32c248cf7474