Closed Bug 804738 Opened 12 years ago Closed 12 years ago

Codegen for named getters/setters hardcodes 'name' for the first argument

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19

People

(Reporter: Ms2ger, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

part 1. Fix codegen for named operations to be consistent about the naming of the string argument.
(deleted), patch
peterv
: review+
Details | Diff | Splinter Review
part 2. Fix codegen for indexed operations to be consistent about the naming of the index argument.
(deleted), patch
peterv
: review+
Details | Diff | Splinter Review
OTOH, the call into native code uses the name from the IDL file, which gives something like FakeDependentString name; ... self->NamedSetter(key, value, rv);
Assignee: nobody → bzbarsky
Whiteboard: [need review]
Attachment #674985 - Flags: review?(peterv) → review+
Attachment #674986 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/02cff46d3ebd https://hg.mozilla.org/integration/mozilla-inbound/rev/3d13288fd977 Thanks for the reviews!
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla19
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: