Closed
Bug 804738
Opened 12 years ago
Closed 12 years ago
Codegen for named getters/setters hardcodes 'name' for the first argument
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: Ms2ger, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
OTOH, the call into native code uses the name from the IDL file, which gives something like
FakeDependentString name;
...
self->NamedSetter(key, value, rv);
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #674985 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #674986 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → bzbarsky
Whiteboard: [need review]
|
||
Updated•12 years ago
|
Attachment #674985 -
Flags: review?(peterv) → review+
|
|
||
Updated•12 years ago
|
Attachment #674986 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/02cff46d3ebd https://hg.mozilla.org/integration/mozilla-inbound/rev/3d13288fd977 Thanks for the reviews!
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla19
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/02cff46d3ebd https://hg.mozilla.org/mozilla-central/rev/3d13288fd977
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•