Closed Bug 805138 Opened 12 years ago Closed 12 years ago

Use "mochitest-N" across the board rather than "mochitest(s)?-N(\/Z)?"

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(3 files, 2 obsolete files)

Buildernames currently used include: * mochitest-N * mochitests-N/T * mochitest-other * mochitest-browser-chrome and now on Cedar (post bug 804026): * mochitests-N We should: (a) Stick to always using the singular form (like we do for reftest/crashtest etc) (b) Get rid of the forward slash onwards This bug will make the buildbot related changes & I'll file dependants for TBPL/OrangeFactor etc.
Attached patch singular mochitest (obsolete) (deleted) — Splinter Review
Attachment #674857 - Flags: review?(rail)
Attachment #674857 - Flags: feedback?(bmo)
Comment on attachment 674857 [details] [diff] [review] singular mochitest lgtm
Attachment #674857 - Flags: review?(rail) → review+
Comment on attachment 674857 [details] [diff] [review] singular mochitest Thank you for the patch - unfortunately I didn't realise you were also working on this (I'd set myself as the assignee when filing, though this is probably not very clear in the bugmail), so have been creating patches myself too. The patches I have change the naming everywhere, rather than just in mozharness so are a superset of this one. Hope this didn't waste too much of your time, sorry!
Attachment #674857 - Flags: feedback?(bmo)
Attached patch buildbotcustom v1 (obsolete) (deleted) — Splinter Review
* Gets rid of the forward slash suffix * Updates the trychooser tests to match the new output from this patch and the others in the series * Also removes the forward slashes from reftests in the trychooser tests, given that they've been gone for a while now
Attachment #675101 - Flags: review?(aki)
Attached patch buildbot-configs v1 (deleted) — Splinter Review
Attachment #674857 - Attachment is obsolete: true
Attachment #675105 - Flags: review?(aki)
Attached patch buildapi v1 (deleted) — Splinter Review
Attachment #675106 - Flags: review?(aki)
Blocks: 805418
Blocks: 805423
Attachment #675105 - Flags: review?(aki) → review+
Comment on attachment 675101 [details] [diff] [review] buildbotcustom v1 We may also need to fix the try chooser logic here: http://hg.mozilla.org/build/buildbotcustom/file/a2afae086fe0/try_parser.py#l27
Attachment #675101 - Flags: review?(aki) → review+
Attachment #675106 - Flags: review?(aki) → review+
Attached patch buildbotcustom v2 (deleted) — Splinter Review
Ah yes, try_parser.py did need changing too (only difference from the v1 patch). I've taken out the mochitest-N special-casing, since the suite names will now be covered by the else clause :-) Requesting re-review for sanity check.
Attachment #675101 - Attachment is obsolete: true
Attachment #675209 - Flags: review?(aki)
Comment on attachment 675209 [details] [diff] [review] buildbotcustom v2 I *think* that's good.
Attachment #675209 - Flags: review?(aki) → review+
In production.
Thank you :-)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 806995
Blocks: 805419
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: