The work we've done for b2g has invalidated some of the mochitests, and to reduce confusion they were removed from the b2g identity patch in bug 794680. In particular, we have concluded that our implementation in May, in which doReady always following doLogin and doLogout, was incorrect. (doReady should not follow doLogout or doLogin; it should only occur after watch.) Now that the sequence of browserid events has been implemented differently, we should tweak the tests and reinstate them before identity is preffed on for desktop firefox.

mochitest-{2,5} currently timing out

This depends on bug 929243 to pass Try push: https://tbpl.mozilla.org/?tree=Try&rev=4a9a9014ef5d I don't believe I made substantial changes, if any, to the tests and they were already reviewed. toolkit/identity/ tests need some fixing.

Hmm... I get the following errors at the end of my mochitest-plain run: 0:44.00 2 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/identity/tests/test_identity_idp_auth_basics.html | uncaught exception - NS_ERROR_FACTORY_NOT_REGISTERED: at http://mochi.test:8888/tests/dom/identity/tests/head_identity.js:22 0:44.00 11 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/identity/tests/test_identity_idp_prov_basics.html | uncaught exception - NS_ERROR_FACTORY_NOT_REGISTERED: at http://mochi.test:8888/tests/dom/identity/tests/head_identity.js:22 0:44.00 19 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/identity/tests/test_identity_rp_basics.html | uncaught exception - NS_ERROR_FACTORY_NOT_REGISTERED: at http://mochi.test:8888/tests/dom/identity/tests/head_identity.js:22 I've applied the patch in bug 929243, and this on top of it.

(In reply to Jed Parsons (use needinfo, please) [:jedp, :jparsons] from comment #3) > Hmm... I get the following errors at the end of my mochitest-plain run: Are you sure you built all three of dom/identity/ toolkit/identity/ and browser/app/?

I did, yes. Actually, it was a completely fresh build, with patches applied to latest m-c. I'm sorry I didn't have time on Friday to dig deeper. I'll jump on it on Monday.

I'm sorry I haven't made much progress here; I've had the flu for the past three days and it's kept me mostly horizontal, away from the computer.

Comment on attachment 8347469 [details] [diff] [review] v.1 Re-add dom/identity/ tests Hrm. I'm still getting failures. This is with today's m-c, 929243_v1.patch applied, and then 805602_identity_tests_dom_v1.patch applied. Fresh clobber build. I get: 11:25.44 40 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/identity/tests/test_identity_idp_prov_basics.html | Test timed out. 11:25.44 76 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/identity/tests/test_identity_rp_basics.html | Caught exception - Error 11:25.44 77 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/identity/tests/test_identity_rp_basics.html | Test timed out. Is everything passing for you locally?

These tests are unlikely to come back from the dead in a useful fashion.