Closed Bug 80598 Opened 24 years ago Closed 22 years ago

View source window does not focus the content area when it's brought up

Categories

(Core Graveyard :: View Source, defect)

Product:
Core Graveyard
Component:
View Source
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bzbarsky, Assigned: stephend)

References

Details

Attachments

(1 file)

proposed patch
(deleted), patch
Details | Diff | Splinter Review
See the 2001-05-12 20:22 comment in bug 78419 for a description of the problem. Basically, view source currently requires a click in the content area for find and the like to work....
Attached patch proposed patch (deleted) — — Splinter Review
reviews?
Keywords: mozilla0.9.1, patch, review
r=blake on IRC, but ccing smfr because Blake says that smfr did something so that this call to focus() should not be needed...
I just remember Simon fixing that bug, but don't know if he fixed it by manually focusing the content area in Navigator (as you're doing it here), or by focusing the find dialog's parent window from the back end.
I don't think anything I changed would affect focus in view source. The patch seems like a good thing to do.
Alec, could you sr?
Keywords: review → approval
sr=alecf
Can someone checkin this patch when the tree opens? Stephen?
Assignee: blakeross → stephend
accepting. already mailed drivers, and I'll check in when given the go-ahead.
Status: NEW → ASSIGNED
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Blocks: 83989
Fix checked in. Thanks to all.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Will the fix solve bug 82663?
Yes.
This is fixed for View Source from a browser window but not from a mail message. Is that a different bug? And btw it doesn't fix 82663. (using 2001061206 win32-installer)
OK. Read bug 82663 again. No, this does _not_ fix it. bug 82663 will get fixed when Doron lands his view source UI. "View message source" in mailnews does not use the view source window. It uses a window of its own -- that should be a separate bug.
vrfy fixed using 2001.06.19.08 comm bits on linux and mac, and 2001.06.19.11 comm bits on winnt.
Status: RESOLVED → VERIFIED
Reopening. Bug 206398 and bug 199481 both state that this bug exists (again). I can confirm this with trunk build 2003051908 on Win2k.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
*** Bug 206398 has been marked as a duplicate of this bug. ***
Wait! I vcannot reproduce this with the build given aboce. But the bug still seems to be alive again.
Um... this was refixed a few days ago by Neil... it had a nice separate bug and all. Resolving fixed, again.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
bryner actually (after he regressed it)
w4m with recent builds.
Status: RESOLVED → VERIFIED
Component: XP Apps: GUI Features → ViewSource
Product: Browser → Seamonkey
Product: SeaMonkey → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: