Closed Bug 806352 Opened 12 years ago Closed 12 years ago

[Contacts] Sending SMS from contact detail doesn't open Message app in edit mode

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
VERIFIED FIXED
Project Flags:
blocking-basecamp +

People

(Reporter: dscravaglieri, Assigned: borjasalguero)

References

Details

(Keywords: smoketest, unagi)

Attachments

(1 file)

PR
(deleted), text/html
etienne
: review+
Details
gecko: fa5609f4ae9fb3a70bc76ecaa62307a4ff1496bd gaia: 58ffd5f5319f865411960f4c81f763a2a4174d71 1- Open existing Contact 2- Tap "Message" button to send a message Expected: Open SMS app in edit mode with contact phone number filled. Actual: Open SMS app in list mode.
Summary: [Contacts] Sending SMS from contact detail doesn't open Massage app in edit mode → [Contacts] Sending SMS from contact detail doesn't open Message app in edit mode
blocking-basecamp: --- → ?
Keywords: unagi
smoke-test failures take highest priority.
Assignee: nobody → fbsc
Severity: normal → critical
Keywords: smoketest
Priority: -- → P1
blocking-basecamp: ? → +
Could you explain the scenario? What do you mean with 'edit-mode'?
Works for me. Please re-open if it still happen.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Works for me also on 8/30 build.
This issue re-appears in build: gecko-b2g18: 71fb5406a8f7 gaia: 1eb1c656b3ac608d846b15b15dc13254be5240a7
Status: RESOLVED → REOPENED
blocking-basecamp: + → ?
Resolution: WORKSFORME → ---
I think this happens when a thread from said number doesn't exist yet. I can have a patch today if nobody else comes by.
Julien! While testing your branch I've fixed this bug in my local branch, so if you merge the other one I can make the PR. The error was in line 149 of the new code, in 'markasunread' because as you said, if the branch does not exist, it's impossible to remove the 'unread' class.
Borja, then just upload your patch here, I'll review it after having merged my patch :) Marking depending on 822055 so that we don't mess up.
Depends on: 822055
Attached file PR (deleted) —
Attachment #696713 - Flags: review?(felash)
Comment on attachment 696713 [details] PR Stealing the review...
Attachment #696713 - Flags: review?(felash) → review+
[:etienne] This one now is not bb+, is bb?.... I need approval-gaia-master?
Comment on attachment 696713 [details] PR NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #696713 - Flags: approval-gaia-master?(21)
Comment on attachment 696713 [details] PR This one was blocking+ before beeing reopened. Let's assume this is the same status.
Attachment #696713 - Flags: approval-gaia-master?(21)
anyway this is a smoketest blocker so..
Borja, I landed Bug 822055, you can go on :)
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Verified fixed Unagi build 20130102070202.
Status: RESOLVED → VERIFIED
Blocks: 835645
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: