Closed
Bug 806690
Opened 12 years ago
Closed 12 years ago
Port browser_privatebrowsing_openlocation.js to the new per-window PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: ehsan.akhgari, Assigned: bellindira)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_openlocation.js
In order to port this test, the file needs to be copied to the perwindow/ directory, and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.
Updated•12 years ago
|
Assignee: nobody → bellindira
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #681284 -
Flags: review?(ehsan)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #681284 -
Attachment is obsolete: true
Attachment #681284 -
Flags: review?(ehsan)
Attachment #681287 -
Flags: review?(ehsan)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 681287 [details] [diff] [review]
Added Test Case per window
Review of attachment 681287 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks a lot! I'll fix the nit below before landing, but note that the keep_current_session pref will go away in per-window PB mode.
::: browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_openlocation.js
@@ +6,5 @@
> // mode without leaving any trace of the URLs visited.
>
> function test() {
> // initialization
> gPrefService.setBoolPref("browser.privatebrowsing.keep_current_session", true);
Setting this pref is not needed any more.
Attachment #681287 -
Flags: review?(ehsan) → review+
Reporter | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Reporter | ||
Comment 6•12 years ago
|
||
This test times out on Mac on Birch:
https://tbpl.mozilla.org/php/getParsedLog.php?id=17497747&tree=Birch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 7•12 years ago
|
||
I think this patch should fix this test: https://hg.mozilla.org/mozilla-central/rev/05865f2b8171
Reporter | ||
Comment 8•12 years ago
|
||
Yeah, that wasn't enough. Backed out that patch for now: https://hg.mozilla.org/mozilla-central/rev/d4a0fcdf66ee
Reporter | ||
Comment 9•12 years ago
|
||
This test failure turned out to be a bigger issue, and I filed bug 817463 for that. The patch that I have there should fix this failure.
Depends on: 817463
Reporter | ||
Comment 10•12 years ago
|
||
Fixed by bug 817463.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•