Closed Bug 817463 Opened 12 years ago Closed 12 years ago

Per-window PB tests depend on the browser.startup.page value to be 0

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

While I was investigating the failure of the test added in bug 806690, I realized that many of these tests open and close windows, and set load listeners for test windows opened. The default value for browser.startup.page (1) means that we try to load about:home, which means that if the test does things such as register content load handlers, it may get the one issued for about:home if the test machine is loaded enough. Fortunately, the fix is very simple. Patch forthcoming.
Attached patch Patch (v1) (deleted) — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #687596 - Flags: review?(josh)
Blocks: 806690
Blocks: 810180
Attachment #687596 - Flags: review?(josh) → review+
No longer blocks: 810180
The try server tells me that this fixes bug 806690. <https://tbpl.mozilla.org/?tree=Try&rev=5b094afb7f54>
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: