Closed Bug 809899 Opened 12 years ago Closed 8 years ago

WebIDL unions are broken in workers

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Unassigned)

References

(Blocks 1 open bug)

Details

I bet they don't really compile.  The problem is the different object representation workers use.  :(
This is not an issue anymore, right?
Flags: needinfo?(bzbarsky)
It can still be if a union includes a type that has both mainthread and worker descriptors with different nativeType.  The relevant code in Codegen.py:

                # FIXME: Unions are broken in workers.  See bug 809899.
                cgthings.append(CGUnionStruct(t, config.getDescriptorProvider(False)))
                cgthings.append(CGUnionStruct(t, config.getDescriptorProvider(False), True))

The arg passed to getDescriptorProvider() there is whether to provide worker descriptors or not.

One thing we could try to do is add a check somewhere that none of our unions in fact include an interface type with different descriptors on mainthread and workers, and then just wontfix this bug...
Flags: needinfo?(bzbarsky)
Depends on: 1257037
Fixed; we no longer have worker descriptors.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.