Closed
Bug 811509
Opened 12 years ago
Closed 12 years ago
login.persona.org does not repaint email text field until user manually resizes the web page (layerizing for scrollable items breaks rendering sometimes)
Categories
(Firefox OS Graveyard :: General, defect, P1)
Tracking
(blocking-basecamp:+, b2g18 fixed)
Tracking | Status | |
---|---|---|
b2g18 | --- | fixed |
People
(Reporter: cpeterson, Assigned: jrmuizel)
References
Details
(Whiteboard: [b2g-gfx])
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
STR:
1. Open https://login.persona.org
2. Tap "Sign In" button
3. When keyboard opens, enter an email address
4. RESULT: No text is displayed in the text field!
5. Pinch the web page to manually resize it
6. RESULT: The email address in the text field is now visible!
Comment 1•12 years ago
|
||
Could have sworn there was a bug on file for this, but I'm failing to find this.
blocking-basecamp: --- → ?
Component: Gaia::Browser → General
Whiteboard: DUPEME
Comment 2•12 years ago
|
||
Is this still a problem? What device, what build? Seems to work on my unagi, Dec 6 build, beta channel.
Comment 3•12 years ago
|
||
(In reply to Milan Sreckovic from comment #2)
> Is this still a problem? What device, what build? Seems to work on my
> unagi, Dec 6 build, beta channel.
I think this happened for me on a more recent build, but I can go check again.
Comment 4•12 years ago
|
||
I can reproduce this with a 2012-12-17 build. Chris, is this something you can work on?
Flags: needinfo?(jsmith) → needinfo?(cpeterson)
Reporter | ||
Comment 5•12 years ago
|
||
I think this is a painting bug, not a keyboard bug. I don't have time to investigate further at the moment..
Flags: needinfo?(cpeterson)
Comment 6•12 years ago
|
||
Jeff, can you see if we can get the regression window?
Assignee: nobody → jmuizelaar
Whiteboard: DUPEME → DUPEME [b2g-gfx]
Updated•12 years ago
|
blocking-basecamp: ? → +
Keywords: regression
Comment 7•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #3)
> (In reply to Milan Sreckovic from comment #2)
> > Is this still a problem? What device, what build? Seems to work on my
> > unagi, Dec 6 build, beta channel.
>
> I think this happened for me on a more recent build, but I can go check
> again.
Well, either I was dreaming or the site changed, but my phone now fails as well with 20121206...
Comment 8•12 years ago
|
||
Removing the regression flag, not sure that it actually is.
Keywords: regression
Assignee | ||
Comment 9•12 years ago
|
||
This reduced test case shows the same problem.
Assignee | ||
Comment 10•12 years ago
|
||
This only seems to happen with 13pt font.
Assignee | ||
Comment 11•12 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> This only seems to happen with 13pt font.
13px I mean.
Comment 12•12 years ago
|
||
Adding a few others who might have ideas.
Assignee | ||
Comment 13•12 years ago
|
||
Some more interesting information: If the height of the text box is explicitly set the problem does not occur. However, I was not able to explicitly set the height of the text box to a height that matched the intrinsic-height.
We also do seem to be drawing the text, it's just not showing up for some reason. Either it's clipped out or we draw something on top of it. I haven't figured out which yet.
bug 818575 has more content in it. People are working on it in core.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Updated•12 years ago
|
Whiteboard: DUPEME [b2g-gfx] → [b2g-gfx]
Assignee | ||
Comment 15•12 years ago
|
||
I'm not convinced this is a dup.
We seem to be painting the text in the wrong place i.e in both cases (working and not)
we paint the glyph at y position of 23. In the broken case it ends up being adjusted to 13. This is happening because there's a CTM on the cairo_context of -10. I'm not sure why yet though.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•12 years ago
|
Target Milestone: --- → B2G C3 (12dec-1jan)
Comment 17•12 years ago
|
||
jeff, any update since you last looked at this?
Assignee | ||
Comment 18•12 years ago
|
||
(In reply to Faramarz (:faramarz) from comment #17)
> jeff, any update since you last looked at this?
No. I've been on vacation.
Assignee | ||
Comment 19•12 years ago
|
||
The difference in translation comes from FrameLayerBuilder::DrawThebesLayer:3268
aContext->Translate(aLayer->GetResidualTranslation() - gfxPoint(offset.x, offset.y))
In this case offset is different between a text field that works and one that doesn't.
The layer bounds are also different between the two cases. In the working case the bounds seem to be the entire page. In the non-working case it seems limited to the textbox.
Assignee | ||
Comment 20•12 years ago
|
||
We are indeed creating an additional layer for the text. We appear to be doing so because a display port is set on the content because we need to be able to scroll it.
Assignee | ||
Comment 21•12 years ago
|
||
So we're triggering this bug because we build a layer when we hit this case http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsGfxScrollFrame.cpp#2089
So that explains what's special about this text box. Next I'll try to figure out why the rendering goes wrong.
Assignee | ||
Comment 22•12 years ago
|
||
This reproduces the problem by using overflow:auto on a div.
Assignee | ||
Updated•12 years ago
|
Summary: login.persona.org does not repaint email text field until user manually resizes the web page → login.persona.org does not repaint email text field until user manually resizes the web page (layerizing for scrollable items breaks rendering sometimes)
Updated•12 years ago
|
Target Milestone: B2G C3 (12dec-1jan) → B2G C4 (2jan on)
Updated•12 years ago
|
Priority: -- → P1
Assignee | ||
Comment 23•12 years ago
|
||
I'm closing this and have opened a new bug 826378 for the remaining problem.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 24•12 years ago
|
||
So Faramarz and I ran into this issue after this patch landed with Twitter and the IBahn site at the hotel. Is this really fixed? I'm going to double check again, otherwise, I'll file a followup.
Comment 25•12 years ago
|
||
Definitely confirmed it's happening on Twitter's sign on page with today's build. Followup coming.
Updated•12 years ago
|
status-b2g18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•