Closed
Bug 812795
Opened 12 years ago
Closed 11 years ago
Greenish aura around the text with the SVG filter applied
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
VERIFIED
FIXED
mozilla29
People
(Reporter: j.tosovsky, Assigned: roc)
References
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
image/svg+xml
|
Details | |
(deleted),
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jwatt
:
review+
longsonr
:
checkin+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121113065533
Steps to reproduce:
I've applied simple 'relief' filter to the gold text, see the attached test case.
Actual results:
There is greenish aura around this text.
Expected results:
No aura is displayed. It seems to be a regression as it looked much better in previous versions.
Comment 1•12 years ago
|
||
Confirmed on Mac too. I suspect this is due to painting text with subpixel AA into the surface to be filtered. Maybe we should not use subpixel AA in filters, masks, etc.?
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
Version: 17 Branch → Trunk
Reporter | ||
Comment 2•12 years ago
|
||
Is there any temporary work around for this?
Comment 3•11 years ago
|
||
seem to be an similar problem as is in Bug 929451
https://bugzilla.mozilla.org/show_bug.cgi?id=929451
Comment 4•11 years ago
|
||
Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/688734575830
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120802041638
Bad:
http://hg.mozilla.org/mozilla-central/rev/074fb996dfd7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120802062038
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=688734575830&tochange=074fb996dfd7
Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a799b5bff84c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120801155239
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b077c43a4306
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120801163038
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a799b5bff84c&tochange=b077c43a4306
Triggered by;
b077c43a4306 Jonathan Watt — Bug 776054 - Flip the prefs to enable the use of display lists for SVG painting and hit-testing. r=roc.
Blocks: 776054
Keywords: regression
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #1)
> Confirmed on Mac too. I suspect this is due to painting text with subpixel
> AA into the surface to be filtered. Maybe we should not use subpixel AA in
> filters, masks, etc.?
I'm not sure about masking. That should be doable. Filters, however, should definitely disable subpixel AA.
Assignee | ||
Comment 7•11 years ago
|
||
I don't see the problem on Linux for some reason. Let me know if these builds fix the problem:
https://tbpl.mozilla.org/?tree=Try&rev=58c0cb34ba6e
Assignee | ||
Comment 8•11 years ago
|
||
Er, these builds: https://tbpl.mozilla.org/?tree=Try&rev=c74f9922d3d4
Assignee | ||
Comment 9•11 years ago
|
||
Assignee: nobody → roc
Attachment #8356968 -
Flags: review?(matt.woodrow)
Comment 10•11 years ago
|
||
The patch doesn't seem to make any difference as far as I can tell. I can see the greenish aura with/without it just the same.
Comment 11•11 years ago
|
||
All is not lost as I see where the patch is going and it just needs this too.
If you apply this and your patch everything displays correctly.
Attachment #8357138 -
Flags: review?(matt.woodrow)
Comment 12•11 years ago
|
||
Comment on attachment 8356968 [details] [diff] [review]
fix
Matt is away for another couple of weeks.
Attachment #8356968 -
Flags: review?(matt.woodrow) → review+
Updated•11 years ago
|
Attachment #8357138 -
Flags: review?(matt.woodrow) → review+
Comment 13•11 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #7)
> I don't see the problem on Linux for some reason.
(FWIW, I do see this bug on Linux (Ubuntu 13.10), with both Nightly and release.)
Comment 14•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=2aacd1b04fec (part 2 only)
Comment 15•11 years ago
|
||
Whiteboard: [leave open]
Updated•11 years ago
|
Attachment #8357138 -
Flags: checkin+
Updated•11 years ago
|
Whiteboard: [leave open]
Assignee | ||
Comment 17•11 years ago
|
||
Comment 18•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Comment 19•11 years ago
|
||
Verified as fixed with latest Aurora on Win 8 x86 and Ubuntu 13.10 x86.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•