Closed
Bug 776054
Opened 12 years ago
Closed 12 years ago
Enable SVG display lists
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jwatt, Assigned: jwatt)
References
(Depends on 4 open bugs, Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
Splitting this out from bug 614732. The plan is to land the patches to implement SVG display lists in bug 614732, and then enable SVG display lists in this bug after the patches for bug 755084 have landed and have been enabled.
Off-main-thread-animations are going to cause problems wherever we've got an nsDisplayTransform that combines a transform due to CSS styling with another transform (e.g. a transform imposed by SVG viewbox or 'transform' attribute). A CSS animation on such an element will modify the layer's transform directly, wiping out any modifications made by SVG.
To fix this, we should ensure that CSS transforms aren't mixed with other transforms in the same nsDisplayTransform. We may need to create multiple nsDisplayTransforms for the same element. That's OK as long as they always have different display-item-keys.
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #648126 -
Flags: review+
Assignee | ||
Comment 3•12 years ago
|
||
As discussed with jet and roc, I've pushed the patch to enable SDL without addressing comment 1 yet. This is in order to gather info on any regressions as early as possible, and to maxixmize our chances of fixing them before the next uplift.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b077c43a4306
Target Milestone: --- → mozilla17
Assignee | ||
Comment 4•12 years ago
|
||
Whether or not this sticks, I've spun comment 1 out into bug 779683 to address it there.
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•12 years ago
|
||
I've been looking through the Talos data since I pushed this. We got both wins and losses.
We got tscrollr wins on three platforms:
Linux: http://goo.gl/0kBVd
Linux64: http://goo.gl/CHQGY
WinXP: http://goo.gl/jcoZU
And tsvgr_opacity regression on three platforms:
WinXP: http://goo.gl/1I2Ig
OSX10.7: http://goo.gl/prrp6
OSX64: http://goo.gl/viosq
I don't think the tsvgr_opacity regressions are worth backing out for. I'd rather keep this enabled and get eyes on any functional regressions.
Assignee | ||
Comment 7•12 years ago
|
||
I'll work on figuring out and fixing the tsvgr_opacity regressions on Tuesday when I'm back online.
Comment 8•12 years ago
|
||
Comment 9•12 years ago
|
||
Apologies - wrong bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•