Closed
Bug 815608
Opened 12 years ago
Closed 12 years ago
[Settings] - fixed headers
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(b2g18 verified)
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g18 | --- | verified |
People
(Reporter: pivanov, Assigned: pivanov)
References
Details
(Whiteboard: BerlinWW, landed in uxbranch)
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/html
|
kaze
:
review+
|
Details |
|
(deleted),
text/html
|
vingtetun
:
approval-gaia-v1+
|
Details |
The <h1> headers should be fixed.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #685613 -
Flags: review?(kaze)
Attachment #685613 -
Flags: feedback?(hello)
|
||
Comment 2•12 years ago
|
||
I still haven't been able to see it working :\
|
|
Assignee | |
Comment 3•12 years ago
|
||
Hey Rafa,
Fabien told me that they found better way to do this and now my patch is obsolete I think. We can ask him for more info when he has more time.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #685613 -
Attachment is obsolete: true
Attachment #685613 -
Flags: review?(kaze)
Attachment #685613 -
Flags: feedback?(hello)
|
|
Assignee | |
Comment 4•12 years ago
|
||
My patch is obsolate and broken but I think that this bug is fixed already.
|
|
Assignee | |
Comment 5•12 years ago
|
||
This patch fix all the headers in Settings.
Attachment #699880 -
Flags: review?(kaze)
|
||
Comment 6•12 years ago
|
||
Comment on attachment 699880 [details]
patch
Pavel, this probably should have been fixed in the UX branch. Asking Vivien if he feels like landing it here.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: little
Testing completed: manual
Risk to taking this patch (and alternatives if risky): none
Attachment #699880 -
Flags: review?(kaze)
Attachment #699880 -
Flags: review+
Attachment #699880 -
Flags: approval-gaia-master?(21)
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: BerlinWW, landed in uxbranch
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → pivanov
|
||
Comment 7•12 years ago
|
||
Comment on attachment 699880 [details]
patch
The PR is against the UX branch so it will come back to me in a different way.
Attachment #699880 -
Flags: approval-gaia-master?(21)
|
|
Assignee | |
Comment 8•12 years ago
|
||
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined:
Testing completed:
Risk to taking this patch (and alternatives if risky):
Attachment #700144 -
Flags: approval-gaia-master?(21)
|
|
||
Comment 9•12 years ago
|
||
Comment on attachment 700144 [details]
patch for Gaia repo
https://github.com/mozilla-b2g/gaia/commit/626e1a98139b0fc8498b67a24ae3be56c7808512
Attachment #700144 -
Flags: approval-gaia-master?(21) → approval-gaia-master+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
No longer depends on: 815609
Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"
Gecko http://hg.mozilla.org/releases/mozilla-b2g18/rev/28b048ffb7a7
Gaia ace1eb32a313da1232bbdf9cff2581a4b036356d
BuildID 20130326070204
Version 18.0
Unagi
Status: RESOLVED → VERIFIED
status-b2g18:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•