Closed Bug 815609 Opened 12 years ago Closed 12 years ago

[BB][headers] - refactoring - removing the child combinators for sub-headers

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

(Whiteboard: BerlinWW)

Attachments

(2 files)

patch
(deleted), text/html
kaze
: review+
lsblakk
: approval-gaia-v1+
Details
patch for UX branch
(deleted), text/html
arnau
: review+
Details
The current CSS selectors are too strict and don't allow to style sub-headers if they aren't direct descendants of a panel. This is a blocker in a few situations, e.g. bug 815608 where we need to nest the panel content in a <div> block.
Depends on: 815608
No longer depends on: 815608
Blocks: 815608
Attached file patch (deleted) —
Attachment #685619 - Flags: review?(kaze)
Attachment #685619 - Flags: feedback?(igonzaleznicolas)
Attachment #685619 - Flags: feedback?(gbrander)
Attachment #685619 - Flags: feedback?(arnau)
Whiteboard: BerlinWW
Assignee: nobody → pivanov
Depends on: 828890
Comment on attachment 685619 [details] patch We have to land this if we want to fix bug 828890… [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: visual inconsistency, see bug 828890 Testing completed: manual Risk to taking this patch (and alternatives if risky): low
Attachment #685619 - Flags: review?(kaze)
Attachment #685619 - Flags: review+
Attachment #685619 - Flags: approval-gaia-master?(21)
Comment on attachment 685619 [details] patch This should land in the UX branch first so it will have QA green light before merging.
Attachment #685619 - Flags: approval-gaia-master?(21) → approval-gaia-master-
Attached file patch for UX branch (deleted) —
Attachment #701787 - Flags: review?
Landed in UX Branch https://github.com/gordonbrander/gaia/commit/588899fb090ba6f898d6186be77be19505f8f579
Whiteboard: BerlinWW → BerlinWW, uxbranch, landed in uxbranch
Thanks again Vivien. The patch was moved in UX branch.
Whiteboard: BerlinWW, uxbranch, landed in uxbranch → BerlinWW
Attachment #685619 - Attachment is obsolete: true
Attachment #685619 - Flags: feedback?(igonzaleznicolas)
Attachment #685619 - Flags: feedback?(gbrander)
Attachment #685619 - Flags: feedback?(arnau)
Attachment #701787 - Flags: review? → review?(arnau)
Comment on attachment 701787 [details] patch for UX branch Nice work Pavel! Let´s try to land this ASAP.
Attachment #701787 - Flags: review?(arnau) → review+
Attachment #685619 - Attachment is obsolete: false
Thanks you can see the patch for gaia/master here : https://github.com/mozilla-b2g/gaia/pull/6655
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
hi Pavel could you please ask for the gaia-approval-v1? so we can request the landing in v1-train and therefore in v1.0.1. Thanks a lot
Attachment #685619 - Flags: approval-gaia-v1- → approval-gaia-v1?(21)
Attachment #685619 - Flags: approval-gaia-v1?(21) → approval-gaia-v1?
Does the risk evaluation from comment 2 still stand? I'm finding it hard to believe this is a low risk change when it's in a shared path, and it's only been on master for <1day (limited visibility). Also, does this patch have any value if landed without bug 828890?
Yep the risk is very low. We need this [BB] improvement for bug 828890 and Arnau need this one for some other bug I think.
I don't see an answer to the second part of the questions in comment 10 - does this have value if landed without bug 828890? That bug is currently waiting on review so we'll hold off here for an answer and also for that other bug's nom and risk assessment.
(In reply to Lukas Blakk [:lsblakk] from comment #12) > I don't see an answer to the second part of the questions in comment 10 - > does this have value if landed without bug 828890? It'd be nice for the email app, and a bit for the music app. Currently, we work around the limitations of the CSS here by adding dummy headers in our scroll regions so that we can use the subheading CSS. Removing those dummy headers would be cleaner, and probably ever-so-slightly faster.
Alex, This patch is useful even if bug 828890 is not landed. Thanks!
Comment on attachment 685619 [details] patch Approving for v1-train.
Attachment #685619 - Flags: approval-gaia-v1? → approval-gaia-v1+
v1-train@c7fde1604df1b40b115d83e01f1ec1184d4ec57b
status-b2g18: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: