We have our own custom menu that is shown in a Popup on phones with s/w button. This can be re-used for the new tabs-menu -- following the Android's pattern of PopupMenu. http://developer.android.com/reference/android/widget/PopupMenu.html

This is a refactor of our custom menu. 1. MenuPanel and MenuPopup will be reused -- hence moved out. 2. MenuPopup is enhanced to change the arrow position based on the anchor position and where the PopupWindow will be displayed. 3. There used to be a MenuPresenter inside GeckoApp that took care of showing the menu. As this would be needed for GeckoPopupMenu, and that it ties our custom menu to an activity, I've moved it as an interface inside GeckoMenu. Thereby, anyone can register themselves as a MenuPresenter for a particular menu, and they will take care of showing/hiding the menu.

This is the right patch.

Our version of PopupMenu that closely shadows Android's PopupMenu. Why? - To support it on GB with our awesome custom menu that can show icons and also have a small little arrow pointing to the anchor. How? - Reuse and Recyle. Go green.

Comment on attachment 688436 [details] [diff] [review] Patch (1/2): Move everything out looks like a good refactor

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cefbc286acb https://hg.mozilla.org/integration/mozilla-inbound/rev/62352bbc0547

https://hg.mozilla.org/mozilla-central/rev/7cefbc286acb https://hg.mozilla.org/mozilla-central/rev/62352bbc0547