Closed
Bug 818238
Opened 12 years ago
Closed 12 years ago
TabsTray should have a menu button
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox20 verified)
VERIFIED
FIXED
Firefox 20
| Tracking | Status | |
|---|---|---|
| firefox20 | --- | verified |
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
TabsTray should support a menu for the tabs. This needs a TouchDelegate in phones to account for the "Tail" overlapping.
|
Assignee | |
Comment 1•12 years ago
|
||
A list of four menu items on tabs-tray:
1. New tab
2. New private tab
3. Synced tabs
4. Close all tabs
Attachment #688438 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 2•12 years ago
|
||
And before someone complains that the menu button is hard to hit. Voila!
Attachment #688439 -
Flags: review?(mark.finkle)
|
||
Updated•12 years ago
|
Attachment #688438 -
Flags: review?(mark.finkle) → review+
|
|
||
Updated•12 years ago
|
Attachment #688439 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
Backout and re-landing due to wrong bug number!
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e3fa909ecd4
https://hg.mozilla.org/integration/mozilla-inbound/rev/5aafc6d684f0
(Sriram learns backing things out.. the hard way :( )
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/53a9ec63e32e
https://hg.mozilla.org/mozilla-central/rev/5aafc6d684f0
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Comment 6•12 years ago
|
||
The menu was added for Tabs Tray on the latest Nightly. Closing bug as verified fixed on:
Firefox 20.0a1 (2012-12-06)
Device: Galaxy S2
OS: Android 4.0.3
Status: RESOLVED → VERIFIED
status-firefox20:
--- → verified
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•