User Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20100101 Firefox/17.0 Build ID: 20121128204232 Steps to reproduce: Set "plugins.click_to_play" to "true" in about:config, then went to http://sc2tv.ru/ // and maybe select a stream. Actual results: There's no location bar icon for enabling flash. Expected results: The location bar icon for enabling flash

It works for me: http://i.imgur.com/xkHIi.jpg

It's sometimes work. Try to select another stream (not "mTwDIMAGA FP-Stream - DIMAGA (T)"). After that, the icon will be not visible even after restart browser.

I'm not able to reproduce on Nightly 20.0a1 (2012-12-11) Win 7 x64.

I did test on the nightly. Go to the site, select another steam in string under "Starcraft Wiki" and the icon is gone. However the icon returned after click on "Click here to activate Flash plugin" Here source code (snapshot) for this case: http://snipt.org/xjWb3 A think, a problem in "display: none;" for first player in iframe.

Correction. "another steam" should be "another stream", of course. ___________ Here saved page with this bug: http://ruzanow.ru/test/sc2tv.7z (1.5Mb) Press on "FP VPBenQlTuruk #20 - Turuk (O)" and the icon is gone. //Saved with opera, firefox do some trash.

Looks like the c2p icon display in the location bar is inconsistent for different uses of display:none. In the current Nightly, this test-case (plugin elements surrounding <div> is display:none) shows no click-to-play icon...

... while this one (plugin element display:none) shows the c2p icon in the location bar.

Thanks Ruzanow, I can see the issue now. The CTP doorhanger disappears after clicking the buttons from just above the video, although the CTP overlay is still displayed.

(In reply to Georg Fritzsche [:gfritzsche] from comment #7) > Created attachment 691314 [details] > test-case: plugin in display > > Looks like the c2p icon display in the location bar is inconsistent for > different uses of display:none. ... But the page ruzanow saved is a different but probably related situation: 3 plugins on the page, 2 nested in a display:none element. On channel switch the visible ones nesting <div> goes display:none and the nesting <div> for another plugin goes display:block

Neither test case spawns a plugin with CTP off, and so neither test case should trigger a message. In Georg's test case #2 the problem is that we are attaching an XBL binding to a display:none element, triggering the event. This is incorrect, however: We do not instantiate display:none plugins, so we should not trigger the event until they become "startable". The assumption was that we only attach XBL bindings to items that have a frame, but this appears not to be the case :(

(In reply to John Schoenick [:johns] from comment #11) > Neither test case spawns a plugin with CTP off, and so neither test case > should trigger a message. > > In Georg's test case #2 the problem is that we are attaching an XBL binding > to a display:none element, triggering the event. This is incorrect, however: > We do not instantiate display:none plugins, so we should not trigger the > event until they become "startable". > > The assumption was that we only attach XBL bindings to items that have a > frame, but this appears not to be the case :( I think we broke some of that behavior in trying to get click-to-play to work with plugins going from display:none to display:block before we did the PluginBindingAttached event switch. Maybe if we reverted those changes this would be fixed?

Reproducible on FF 19. No longer reproducible on FF 20.0a2 (2013-02-18). I think this is a dupe of bug 831757 which is fixed now by bug 825804.

Confirmed fixed too: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fcf79680a057&tochange=876652a0c8ef

That pushlog contains bug 825804, so this is looking good.