Closed
Bug 822029
Opened 12 years ago
Closed 12 years ago
Update Valgrind tbpl builds to use XPCOM_CC_RUN_DURING_SHUTDOWN=1
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: gkw, Assigned: gkw)
References
Details
(Keywords: valgrind, Whiteboard: [valgrind])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Valgrind detects a leak of 576 bytes (direct) with nsXBLBinding::GenerateAnonymousContent on the stack, see attached snippet which comes from:
https://tbpl.mozilla.org/php/getParsedLog.php?id=17969239&tree=Firefox&full=1
Guessing Core: DOM, please change component if necessary.
Regression window: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b11065872128&tochange=5ea1c76e4bb3
This seems 32-bit only, not showing up on 64-bit builds.
Is this related to bug 818739, where we do not CC on shutdown?
Assignee | ||
Comment 1•12 years ago
|
||
Adding 3 possibly-related stacks involving:
nsTextControlFrame::CreateAnonymousContent
nsDocumentViewer::InitPresentationStuff
nsNavBookmarks::ResultNodeForContainer
Comment 2•12 years ago
|
||
We do leak now plenty of stuff when shutting down opt builds.
If you want to do leak testing, set XPCOM_CC_RUN_DURING_SHUTDOWN environment variable or use
debug builds.
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #2)
> We do leak now plenty of stuff when shutting down opt builds.
> If you want to do leak testing, set XPCOM_CC_RUN_DURING_SHUTDOWN environment
> variable or use
> debug builds.
These appear on TBPL opt builds run under Valgrind - so no debug builds.
Is the following command correct?
export XPCOM_CC_RUN_DURING_SHUTDOWN=yes
Flags: needinfo?(bugs)
Comment 4•12 years ago
|
||
I'd use =1 but that shouldn't matter. Any value is ok.
Flags: needinfo?(bugs)
Assignee | ||
Updated•12 years ago
|
Severity: major → normal
Component: DOM → Release Engineering: Automation (General)
Keywords: mlk,
regression
OS: Linux → All
Product: Core → mozilla.org
QA Contact: catlee
Hardware: x86 → All
Whiteboard: [valgrind]
Version: Trunk → other
Assignee | ||
Comment 5•12 years ago
|
||
Taking. Patch coming up.
Assignee: nobody → gary
Blocks: 818739
Summary: Valgrind on tbpl detects leak - 576 bytes are definitely lost (direct) with nsXBLBinding::GenerateAnonymousContent on the stack → Update Valgrind tbpl builds to use XPCOM_CC_RUN_DURING_SHUTDOWN=1
Assignee | ||
Updated•12 years ago
|
Attachment #692632 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #692635 -
Attachment is obsolete: true
Assignee | ||
Comment 6•12 years ago
|
||
Sets XPCOM_CC_RUN_DURING_SHUTDOWN=1 prior to execution of PGO tests on Valgrind tbpl builds.
Attachment #692636 -
Flags: review?(ted)
Comment 7•12 years ago
|
||
Hopefully the env variable makes the leak to disappear :)
Updated•12 years ago
|
Attachment #692636 -
Flags: review?(ted) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•12 years ago
|
||
This worked properly! We now have green builds again..
https://tbpl.mozilla.org/?noignore=1&jobname=valgrind&rev=c8a1314aa449
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•