Closed
Bug 824448
Opened 12 years ago
Closed 12 years ago
Convert HTMLHeadingElement to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Dromaeo's dom-attr test uses an <h2>. You can see a before/after at http://dromaeo.com/?id=186938,186941 (esp. the getAttribute and element.property lines).
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #695425 -
Flags: review?(peterv)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #695426 -
Flags: review?(peterv)
Comment 3•12 years ago
|
||
Comment on attachment 695425 [details] [diff] [review] part 1. Rename nsHTMLHeadingElement to mozilla::dom::HTMLHeadingElement. Review of attachment 695425 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/nsHTMLHeadingElement.cpp @@ +9,5 @@ > #include "nsStyleConsts.h" > #include "nsMappedAttributes.h" > #include "nsRuleData.h" > #include "mozAutoDocUpdate.h" > +#include "mozilla/dom/HTMLHeadingElement.h" Include this first, to make sure the header doesn't depend on anything included before it. ::: content/html/content/src/HTMLHeadingElement.h @@ +36,5 @@ > + > + virtual bool ParseAttribute(int32_t aNamespaceID, > + nsIAtom* aAttribute, > + const nsAString& aValue, > + nsAttrValue& aResult); Indentation @@ +39,5 @@ > + const nsAString& aValue, > + nsAttrValue& aResult); > + NS_IMETHOD_(bool) IsAttributeMapped(const nsIAtom* aAttribute) const; > + nsMapRuleToAttributesFunc GetAttributeMappingFunction() const; > + virtual nsresult Clone(nsINodeInfo *aNodeInfo, nsINode **aResult) const; * to the left
Assignee | ||
Comment 4•12 years ago
|
||
> Include this first, to make sure the header doesn't depend on anything included before
> it.
Eh. OK.
Will fix the ParseAttribute indent. No plans to "fix" the copied code. ;)
Whiteboard: [need review]
Updated•12 years ago
|
Attachment #695425 -
Flags: review?(peterv) → review+
Updated•12 years ago
|
Attachment #695426 -
Flags: review?(peterv) → review+
Comment 5•12 years ago
|
||
Hmm, need to add include guards to HTMLHeadingElement.h.
Assignee | ||
Comment 6•12 years ago
|
||
Good catch. Done.
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc6168662099 https://hg.mozilla.org/integration/mozilla-inbound/rev/f5638aa67e23
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla20
Assignee | ||
Comment 8•12 years ago
|
||
Attachment #695854 -
Flags: review?(peterv)
Assignee | ||
Comment 9•12 years ago
|
||
Pushed the test fix as https://hg.mozilla.org/integration/mozilla-inbound/rev/21865911745c pending review.
Assignee | ||
Comment 10•12 years ago
|
||
As expected, this gave us wins on dom-attr, ranging from 5% to 17% depending on the build configuration.
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dc6168662099 https://hg.mozilla.org/mozilla-central/rev/f5638aa67e23 https://hg.mozilla.org/mozilla-central/rev/21865911745c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment #695854 -
Flags: review?(peterv) → review+
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•