Closed
Bug 824986
Opened 12 years ago
Closed 12 years ago
Move DOMRequest and subclasses to Paris bindings
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
khuey
:
review+
janv
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
This is quite a big patch, but I don't know a good way to split it up. Sorry about that.
Attachment #723270 -
Flags: review?(khuey)
Attachment #723270 -
Flags: feedback?(Jan.Varga)
Comment on attachment 723270 [details] [diff] [review] Patch v1 Review of attachment 723270 [details] [diff] [review]: ----------------------------------------------------------------- All of these interfaces need IID changes. ::: dom/activities/src/Activity.h @@ +47,2 @@ > > Activity(); Is it possible to somehow assert that SetIsDOMBinding was called (in DOMRequest's ctor) in this ctor? ::: dom/base/DOMRequest.cpp @@ +98,5 @@ > + aReadyState.AssignLiteral("done"); > + break; > + default: > + MOZ_NOT_REACHED("Unrecognized readyState."); > + } Mozilla style is switch(foo) { case Bar: DoBaz(); ::: dom/base/DOMRequest.h @@ +34,5 @@ > > NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_INHERITED(DOMRequest, > nsDOMEventTargetHelper) > > + Extraneous \n. @@ +43,5 @@ > + } > + virtual JSObject* > + WrapObject(JSContext* aCx, JSObject* aScope, bool* aTriedToWrap) MOZ_OVERRIDE; > + > + Move one of these '\n's to above WrapObject? @@ +57,5 @@ > + NS_ASSERTION(mDone || mResult == JSVAL_VOID, > + "Result should be undefined when pending"); > + return mResult; > + } > + nsIDOMDOMError* GetError() const \n before the function ::: dom/devicestorage/nsDeviceStorage.h @@ +89,5 @@ > nsRefPtr<mozilla::dom::DOMRequest> mRequest; > }; > > class nsDOMDeviceStorageCursor MOZ_FINAL > + : public mozilla::dom::DOMRequest Why not DOMCursor? ::: dom/webidl/ArchiveRequest.webidl @@ +4,5 @@ > + * License, v. 2.0. If a copy of the MPL was not distributed with this > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > + > +interface ArchiveRequest : DOMRequest { > + readonly attribute ArchiveReader? reader; This should not be nullable. Add appropriate assertions to ArchiveRequest and replace GetReader() with Reader().
Attachment #723270 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Thanks! (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2) > ::: dom/base/DOMRequest.cpp > @@ +98,5 @@ > > + aReadyState.AssignLiteral("done"); > > + break; > > + default: > > + MOZ_NOT_REACHED("Unrecognized readyState."); > > + } > > Mozilla style is > > switch(foo) { > case Bar: > DoBaz(); Really? I hadn't noticed we did anything consistently for switches. Can do, I guess. > ::: dom/devicestorage/nsDeviceStorage.h > @@ +89,5 @@ > > nsRefPtr<mozilla::dom::DOMRequest> mRequest; > > }; > > > > class nsDOMDeviceStorageCursor MOZ_FINAL > > + : public mozilla::dom::DOMRequest > > Why not DOMCursor? No idea what that is.
Comment 4•12 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2) > ::: dom/devicestorage/nsDeviceStorage.h > @@ +89,5 @@ > > nsRefPtr<mozilla::dom::DOMRequest> mRequest; > > }; > > > > class nsDOMDeviceStorageCursor MOZ_FINAL > > + : public mozilla::dom::DOMRequest > > Why not DOMCursor? That is bug 837865 (which will need changes because of this).
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04c24f5d233f https://hg.mozilla.org/mozilla-central/rev/c444f2bfadc4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Updated•12 years ago
|
Attachment #723270 -
Flags: feedback?(Jan.Varga) → feedback+
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•