Closed
Bug 826133
Opened 12 years ago
Closed 12 years ago
Android NDK r8c no longer needs to suppress useless warnings about va_list mangling
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
feedback+
|
Details | Diff | Splinter Review |
Older Android NDKs logged many, many useless warnings about va_list mangling. These warnings were suppressed in bug 760335. Now that mozilla-central is building with NDK r8c (bug 825453 and bug 825151), we no longer need to suppress these warnings with gcc -Wno-psabi.
Attachment #697293 -
Flags: review?(mh+mozilla)
Comment 1•12 years ago
|
||
Fiddling with the dependency list since this doesn't actually block bug 816993 but rather is enabled by it.
Comment 2•12 years ago
|
||
Comment on attachment 697293 [details] [diff] [review]
revert-Wno-psabi.patch
Review of attachment 697293 [details] [diff] [review]:
-----------------------------------------------------------------
::: build/autoconf/android.m4
@@ +143,5 @@
> OBJCOPY="$android_toolchain"/bin/"$android_tool_prefix"-objcopy
>
> CPPFLAGS="-isystem $android_platform/usr/include $CPPFLAGS"
> CFLAGS="-mandroid -fno-short-enums -fno-exceptions $CFLAGS"
> + CXXFLAGS="-mandroid -fno-short-enums -fno-exceptions $CXXFLAGS"
Could you also add -Wno-psabi for older versions of gcc?
check how it's done for MOZ_OPTIMIZE_SIZE_TWEAK in configure.in, for instance.
Attachment #697293 -
Flags: review?(mh+mozilla) → feedback+
Assignee | ||
Comment 3•12 years ago
|
||
The use of -Wno-psabi with new NDKs is harmless, but unnecessary. The va_list warnings when using old NDKs without -Wno-psabi are also harmless, but very annoying.
I would prefer either of those cases than adding more conditional code to configure.in. My motivation for this patch was remove a compiler flag that is no longer necessary. :)
Comment 4•12 years ago
|
||
If the choice is between leaving it everywhere and removing it everywhere, I choose the former.
Assignee | ||
Comment 5•12 years ago
|
||
WONTFIX. Sounds reasonable to me. :)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•