Fixed for buildbot in bug 755781; I need to do the same thing for mozharness unittests+talos.

Needs testing.

We don't do debug talos, so this should do it.

running in staging (debug+opt unittests, opt talos).

This patch: * points unittest simplejson at puppetagain instead of build.m.o * makes --download-symbols a choice between 'ondemand' and 'true' * makes DesktopUnittest.download_and_extract() re-use TestingMixin.download_and_extract() instead of reinventing it ** makes TestingMixin.download_and_extract() support target_unzip_dirs to allow for this Tested, along with the buildbot-configs/custom patches. Debug unittests download+extract the symbols and set symbols path to the directory; opt unittests+talos set the symbols path to the url.

This adds the appropriate --download-symbols command line options to mozharness unittests. |--download-symbols true| for debug |--download-symbols ondemand| for opt and nothing for platforms or branches that don't have symbols enabled.

This changes mozharness talos' |--download-symbols| to |--download-symbols ondemand|. This will burn if we run mozharness talos without both a reconfig + the mozharness patch landed. However, mozharness talos is currently limited to cedar, so that's not a blocker.

Comment on attachment 698150 [details] [diff] [review] (configs) add --download-symbols to mh unittests http://hg.mozilla.org/build/buildbot-configs/rev/caad771931f9

Comment on attachment 698152 [details] [diff] [review] (custom) s,--download-symbols,--download-symbols ondemand, http://hg.mozilla.org/build/buildbotcustom/rev/a89b4f0ab90c

Joel, Jeff: If we reconfig here without landing the mozharness patch, talos on Cedar will burn until that's landed (see comment 6). Just a heads up.

in production

Comment on attachment 698149 [details] [diff] [review] (mozharness) --download-symbols [true|ondemand], with fixes http://hg.mozilla.org/build/mozharness/rev/60f39f4ac05d

I see it working on cedar :)