Closed Bug 82652 Opened 24 years ago Closed 23 years ago

Editable menulist modifications needed.

Categories

(Core :: XUL, defect)

x86
Windows NT
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla0.9.2

People

(Reporter: cmanske, Assigned: cmanske)

References

Details

(Keywords: regression)

Attachments

(7 files)

The xul widget <menulist editable="true"> combines a textbox (input field) with a popup menulist. The default behavior for this has been modified according to expected standards, but there are bugs with the current behavior. This bug is to track the necessary changes neede to make it work correctly in Composer's Advanced edit dialog (bug 71743) and in the Forms Manager (bug to be filed soon.)
Adding blockers.
Blocks: 71743, 82655
Severity: normal → critical
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Ready for review
Keywords: patch, regression, review
Whiteboard: FIX IN HAND need r=, sr=
When I apply the patch given here, I get the message: Patching file menulist.xml using Plan A... Hunk #1 failed at 174. Hunk #2 failed at 269. 2 out of 2 hunks failed--saving rejects to menulist.xml.rej done
I believe that the reason the patch is failing is that I am applying it against version 1.2 of the file. The patch is against 1.1. And the difference between 1.1 and 1.2 involve the same area that this patch involves. Charlie, you probably need to update your file and then regenerate the patch.
Attached patch Updated patch (deleted) — Splinter Review
Wait! last one won't work either.
You forgot to remove the diagnostic dump statements from your patch.
r=kin
sr=hewitt
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND
Blocks: 83989
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Whiteboard: FIX IN HAND → fixed, reviewed, a=asa
checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: fixed, reviewed, a=asa
No longer blocks: 82655
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: