Closed
Bug 82652
Opened 24 years ago
Closed 23 years ago
Editable menulist modifications needed.
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9.2
People
(Reporter: cmanske, Assigned: cmanske)
References
Details
(Keywords: regression)
Attachments
(7 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
The xul widget <menulist editable="true"> combines a textbox (input field) with
a popup menulist. The default behavior for this has been modified according
to expected standards, but there are bugs with the current behavior. This bug
is to track the necessary changes neede to make it work correctly in Composer's
Advanced edit dialog (bug 71743) and in the Forms Manager (bug to be filed soon.)
Assignee | ||
Comment 1•24 years ago
|
||
Adding blockers.
Assignee | ||
Comment 2•24 years ago
|
||
Comment 4•24 years ago
|
||
When I apply the patch given here, I get the message:
Patching file menulist.xml using Plan A...
Hunk #1 failed at 174.
Hunk #2 failed at 269.
2 out of 2 hunks failed--saving rejects to menulist.xml.rej
done
Comment 5•24 years ago
|
||
I believe that the reason the patch is failing is that I am applying it against
version 1.2 of the file. The patch is against 1.1. And the difference between
1.1 and 1.2 involve the same area that this patch involves.
Charlie, you probably need to update your file and then regenerate the patch.
Assignee | ||
Comment 6•24 years ago
|
||
Assignee | ||
Comment 7•24 years ago
|
||
Wait! last one won't work either.
Assignee | ||
Comment 8•24 years ago
|
||
Assignee | ||
Comment 9•24 years ago
|
||
Comment 10•24 years ago
|
||
You forgot to remove the diagnostic dump statements from your patch.
Assignee | ||
Comment 11•23 years ago
|
||
Assignee | ||
Comment 12•23 years ago
|
||
Assignee | ||
Comment 13•23 years ago
|
||
r=kin
Comment 14•23 years ago
|
||
sr=hewitt
Assignee | ||
Comment 15•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND
Comment 16•23 years ago
|
||
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Updated•23 years ago
|
Whiteboard: FIX IN HAND → fixed, reviewed, a=asa
Assignee | ||
Comment 17•23 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: fixed, reviewed, a=asa
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•