This might be intentional. The tab count indicator showcases the regular tab count and not the private tab count.

(When viewed from within a private tab or in about:privatebrowsing)

One solution might be to only show the count for the kind of tabs you are currently in. So for example if you have 10 normal tabs and 2 private tabs open, the counter should change from 10 to 2 if you toggle from a normal tab to a private one.

I did a grep of Tabs.getCount(), and it looks like we're only using it to update the browser toolbar count, so this patch should be safe. To make its behavior more clear, though, maybe we should rename it to getDisplayedCount?

Comment on attachment 714134 [details] [diff] [review] Return the tab count of the current private state I agree with the rename to getDisplayCount

Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/00c09b326fee https://hg.mozilla.org/integration/mozilla-inbound/rev/014e88baa216 for 02-16 00:24:34.748 E/GeckoAppShell( 1802): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main") 02-16 00:24:34.748 E/GeckoAppShell( 1802): java.util.ConcurrentModificationException 02-16 00:24:34.748 E/GeckoAppShell( 1802): at java.util.HashMap$HashIterator.nextEntry(HashMap.java:795) 02-16 00:24:34.748 E/GeckoAppShell( 1802): at java.util.HashMap$ValueIterator.next(HashMap.java:827) 02-16 00:24:34.748 E/GeckoAppShell( 1802): at org.mozilla.gecko.Tabs.getDisplayCount(Tabs.java:105) 02-16 00:24:34.748 E/GeckoAppShell( 1802): at org.mozilla.gecko.BrowserToolbar.refresh(BrowserToolbar.java:1159)

This good for another attempt?

Oops - this was landed with the wrong bug number. The ConcurrentModificationException from comment 7 can still happen infrequently; once bug 844407 (which is r+'ed and mostly ready) lands, though, that should be fixed. https://hg.mozilla.org/integration/mozilla-inbound/rev/cb2ccaf0b894 https://hg.mozilla.org/mozilla-central/rev/cb2ccaf0b894

Comment on attachment 714134 [details] [diff] [review] Return the tab count of the current private state Note that this must be uplifted with bug 844407 to fix the exception from comment 7. [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 582244 (pb) User impact if declined: tab count will show total number of tabs instead of number of tabs for the current private state Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): low risk String or UUID changes made by this patch: none

We'll wait for bug 844497 to be reviewed then.

(In reply to Lukas Blakk [:lsblakk] from comment #11) > We'll wait for bug 844497 to be reviewed then. Sorry, I meant bug 844407

Comment on attachment 714134 [details] [diff] [review] Return the tab count of the current private state Please make sure to land bug 844407 when landing this.

Looks good on trunk (03/15)