Closed
Bug 832463
Opened 12 years ago
Closed 12 years ago
rename balrog-client.py (and associated bits) to balrog-submitter.py
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
(Whiteboard: [balrog])
Attachments
(2 files)
|
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
...because "client" is a term already used in talking about a Firefox or other application that queries for an update.
|
Assignee | |
Comment 1•12 years ago
|
||
I've put in a symlink to the old name for now to avoid any failures while we switch over.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #714048 -
Flags: review?(rail)
|
||
Updated•12 years ago
|
Attachment #714047 -
Flags: review?(rail) → review+
|
|
||
Updated•12 years ago
|
Attachment #714048 -
Flags: review?(rail) → review+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #714047 -
Flags: checked-in+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #714048 -
Flags: checked-in+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Just realized that Windows will probably fail because it doesn't support symlinks. It'll be fixed once the buildbotcustom patch is in production.
|
|
Assignee | |
Comment 4•12 years ago
|
||
To my surprise this didn't even work for Linux. The buildbotcustom patch is headed to production today though, so meh.
|
|
Assignee | |
Comment 5•12 years ago
|
||
I missed an import:
Traceback (most recent call last):
File "/builds/slave/m-cen-lx-l10n-ntly-00000000000/tools/scripts/updates/balrog-submitter.py", line 11, in <module>
from balrog.submitter.cli import NightlyRunner
File "/builds/slave/m-cen-lx-l10n-ntly-00000000000/tools/lib/python/balrog/submitter/cli.py", line 7, in <module>
from balrog.client.api import SingleLocale
ImportError: No module named client.api
I landed a bustage fix in https://hg.mozilla.org/build/tools/rev/7a8342a33cc2. Things are all good now.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 6•12 years ago
|
||
Woot!
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
|
|
||
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•