Closed
Bug 833949
Opened 12 years ago
Closed 12 years ago
convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsCOMArray
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 21.0
People
(Reporter: aceman, Assigned: aceman)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Defined as a variable in:
mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations)
line 738 -- m_cachedMemCacheEntries->AppendElement(cacheEntrySupports);
line 750 -- m_cachedMemCacheEntries->RemoveElement(cacheEntrySupports);
mailnews/base/util/nsMsgMailNewsUrl.h (View Hg log or Hg annotations)
line 60 -- nsCOMPtr<nsISupportsArray> m_cachedMemCacheEntries;
Referenced in:
mailnews/base/util/nsMsgMailNewsUrl.cpp (View Hg log or Hg annotations)
line 732 -- if (!m_cachedMemCacheEntries)
line 733 -- NS_NewISupportsArray(getter_AddRefs(m_cachedMemCacheEntries));
line 734 -- if (m_cachedMemCacheEntries)
line 746 -- if (m_cachedMemCacheEntries)
Attachment #705536 -
Flags: review?(neil)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 705536 [details] [diff] [review]
patch
It's OK but I'd have preferred an nsCOMArray.
Attachment #705536 -
Flags: review?(neil) → review+
Attachment #705536 -
Attachment is obsolete: true
Attachment #706527 -
Flags: review?(neil)
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 706527 [details] [diff] [review]
patch v2
nsCOMArray can do things that nsTArray can't and uses less code. However it does have a weird API, and I'm still waiting on review to fix that :-(
Attachment #706527 -
Flags: review?(neil) → review+
Keywords: checkin-needed
Summary: convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsTArray → convert nsMsgMailNewsUrl::m_cachedMemCacheEntries from nsISupportsArray to nsCOMArray
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
You need to log in
before you can comment on or make changes to this bug.
Description
•