:aceman Reporter
	Description • 12 years ago

nsresult nsMsgCompose::BuildMailListArray(nsIAbDirectory* parentDir,
                                          nsISupportsArray* array)

and

nsresult nsMsgCompose::GetMailListAddresses(nsString& name, nsISupportsArray* mailListArray, nsIMutableArray** addressesArray)

	Magnus Melin [:mkmelin]
	Comment 2 • 12 years ago

Comment on attachment 705567 [details] [diff] [review]
patch

Review of attachment 705567 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok afaikt.

	neil@parkwaycc.co.uk Assignee
	Comment 3 • 12 years ago

Comment on attachment 705567 [details] [diff] [review]
patch

>       nsMsgMailList* mailList;
>-      rv = enumerator->CurrentItem((nsISupports**)&mailList);
>+      rv = enumerator->GetNext((nsISupports**)&mailList);
I'm sorry but I can't perpetuate this horror, the code needs a rewrite.

	neil@parkwaycc.co.uk Assignee
	Comment 4 • 12 years ago

* Moved more of the fullname init code into the constructor
* Changed the array from an nsISupportsArray to an nsTArray
* Rewrote GetMailListAddresses to use an IndexOf comparator

	:aceman Reporter
	Comment 5 • 12 years ago

Quite involved rewrite, even the class changed to struct :)

	Mark Banner (:standard8)
	Comment 6 • 12 years ago

Comment on attachment 705819 [details] [diff] [review]
Proposed patch

Review of attachment 705819 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and the unit tests pass :-)

	neil@parkwaycc.co.uk Assignee
	Comment 7 • 12 years ago

Pushed comm-central changeset c52e29d0ff20.