(no longer active) Assignee
	Description • 11 years ago

      No description provided.

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 3 • 11 years ago

Comment on attachment 709508 [details] [diff] [review]
Part 2: Move HTMLBRElement to WebIDL bindings

Review of attachment 709508 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Bindings.conf
@@ +353,5 @@
>    'hasInstanceInterface': 'nsIDOMHTMLBodyElement',
>  },
>  
> +'HTMLBRElement': {
> +  'hasInstanceInterface': 'nsIDOMHTMLBRElement',

Nit: four-space indentation.

	(no longer active) Assignee
	Comment 4 • 11 years ago

(In reply to comment #3)
> Comment on attachment 709508 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=709508
> Part 2: Move HTMLBRElement to WebIDL bindings
> 
> Review of attachment 709508 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/bindings/Bindings.conf
> @@ +353,5 @@
> >    'hasInstanceInterface': 'nsIDOMHTMLBodyElement',
> >  },
> >  
> > +'HTMLBRElement': {
> > +  'hasInstanceInterface': 'nsIDOMHTMLBRElement',
> 
> Nit: four-space indentation.

Just copied the surrounding style.

	Boris Zbarsky [:bzbarsky]
	Comment 5 • 11 years ago

Comment on attachment 709507 [details] [diff] [review]
Part 1: Rename nsHTMLBRElement to mozilla::dom::HTMLBRElement

r=me

	Boris Zbarsky [:bzbarsky]
	Comment 6 • 11 years ago

Comment on attachment 709508 [details] [diff] [review]
Part 2: Move HTMLBRElement to WebIDL bindings

Please put the relevant spec links right before the interface and partial interface as well.

r=me

	(no longer active) Assignee
	Comment 7 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/eef81a083976
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8f79381117e

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/eef81a083976
https://hg.mozilla.org/mozilla-central/rev/e8f79381117e