Closed
Bug 837520
Opened 12 years ago
Closed 12 years ago
Convert HTMLBRElement to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #709508 -
Flags: review?(bzbarsky)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 709508 [details] [diff] [review]
Part 2: Move HTMLBRElement to WebIDL bindings
Review of attachment 709508 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bindings/Bindings.conf
@@ +353,5 @@
> 'hasInstanceInterface': 'nsIDOMHTMLBodyElement',
> },
>
> +'HTMLBRElement': {
> + 'hasInstanceInterface': 'nsIDOMHTMLBRElement',
Nit: four-space indentation.
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to comment #3)
> Comment on attachment 709508 [details] [diff] [review]
> --> https://bugzilla.mozilla.org/attachment.cgi?id=709508
> Part 2: Move HTMLBRElement to WebIDL bindings
>
> Review of attachment 709508 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: dom/bindings/Bindings.conf
> @@ +353,5 @@
> > 'hasInstanceInterface': 'nsIDOMHTMLBodyElement',
> > },
> >
> > +'HTMLBRElement': {
> > + 'hasInstanceInterface': 'nsIDOMHTMLBRElement',
>
> Nit: four-space indentation.
Just copied the surrounding style.
|
||
Comment 5•12 years ago
|
||
Comment on attachment 709507 [details] [diff] [review]
Part 1: Rename nsHTMLBRElement to mozilla::dom::HTMLBRElement
r=me
Attachment #709507 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 709508 [details] [diff] [review]
Part 2: Move HTMLBRElement to WebIDL bindings
Please put the relevant spec links right before the interface and partial interface as well.
r=me
Attachment #709508 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eef81a083976
https://hg.mozilla.org/mozilla-central/rev/e8f79381117e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•