We need to root to fix this.

Comment on attachment 709692 [details] [diff] [review] Support 'any' values in sequences and dictionaries. >+class RootedJSValue { Not sure about conventions in this file, but { should be in the next line, and parameters should in form aFoo

Comment on attachment 709692 [details] [diff] [review] Support 'any' values in sequences and dictionaries. Review of attachment 709692 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/BindingDeclarations.h @@ +258,5 @@ > +private: > + // Don't allow copy-construction of these objects, because it'll do the wrong > + // thing with our flag mCx. > + RootedJSValue(const RootedJSValue&) MOZ_DELETE; > + Trailing whitespace

Conventions so far are what I make up, but yeah, will do. So I thought of one issue with this approach: I'll have to change my setTimeout patch to individually root all of the arguments to setTimeout instead of using an array rooter as I do now. I can probably live with that, because we can't use the array rooters in binding code, sadly.

Hrm. But then I'll need a JSContext in the C++ code... I wonder whether I should only support this for dictionaries for now and keep sequences as they were. I think I'm going to go ahead and do that, in fact.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e0f4418ad0c but I forgot to change the commit message to only talk about dictionaries... :(