ayman maat :maat Reporter
	Description • 12 years ago

**DESCRIPTION**
No indication of why Message, Wall post and view Facebook profile CTAs are disabled when wifi connection is lost

**PATH**
1) import some Facebook friends into contact list
2) disconnect wifi (to simulate unexpected loss of wifi connection)
3) navigate to the contact detail page of a contact that is linked to facebook

**EXPECTED**
one of two things:

1) either the Message, Wall post and view Facebook profile CTSs will be disabled and a messages will be presented with them within the contact detail view explaining that there is no network connection, or 
2) the Message, Wall post and view Facebook profile CTSs will be active but upon selecting them the user will receive a message saying that there is no network connection (this is probably the most appropriate given that it follows a similar president set by the behavior of the dialer when there is no SIM and the SMS when there is no SIM or there is network issues)

**ACTUAL**
Message, Wall post and view Facebook profile CTAs are disabled and the end user is given no explanation as to why. They are therefore faced with an error (CTAs being unexpectedly disabled) that they have to work out the cause of / solution to. End user error identification and recovery / resolution is hampered by the fact that the 'unlink contact' CTA (which requires network connection) remains active at all time.

	Jose Manuel Cantera
	Comment 1 • 12 years ago

thanks for spotting this. once we have a visual design, which can be similar to those already done for Contact settings, we can implement it.

	ayman maat :maat Reporter
	Comment 2 • 12 years ago

no problem jose. RFI to victoria to produce the necessary visuals for Jose or direct him to where the assets are if they already exist. contact me directly Vitoria if you require and further input / clarification.

	Jose Manuel Cantera
	Comment 3 • 12 years ago

Sergi, 

Any progress on this?

thanks

	Sergi
	Comment 4 • 11 years ago

Sorry Jose Manuel, is this bug still open?

Thanks

(In reply to Jose M. Cantera from comment #3)
> Sergi, 
> 
> Any progress on this?
> 
> thanks

	ayman maat :maat Reporter
	Comment 5 • 11 years ago

Requesting QA re comment 4

	Francisco Jordano [:arcturus] [:francisco] Assignee
	Comment 6 • 11 years ago

Sorry, Jose Manuel is on PTO, and as I see ... yes this is still open, waiting for a QA check as Ayman just set ;)

	rafael.marquez
	Comment 7 • 11 years ago

Hello Ayman,
To review the bug, I need know the device and branch.

	ayman maat :maat Reporter
	Comment 8 • 11 years ago

(In reply to rafael.marquez from comment #7)
> Hello Ayman,
> To review the bug, I need know the device and branch.

sorry rafael for not including this information, please needinfo me if you need something from me so i pick it up :)

have tested today and issue is still present on:

unagi-ICS.
master.
Rel0.4.
Sprint12.B-98.
Gecko-0c057b4.
Gaia-686e308

	Jose Manuel Cantera
	Comment 9 • 10 years ago

Fang,

this is an old bug that had visual design pending. if you provide such a visual design we can fix it

thanks

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 10 • 10 years ago

Hi Jose, 

I wonder why do we really need to disable the action buttons here? If users tap the button, it will bring up browser (as an inline activity), and if there has no internet connection, the browser will display corresponding information there, right? I think disabling the buttons with no reason or providing a confirm window is quite redundant. What do you say? Thanks!

	Jose Manuel Cantera
	Comment 11 • 10 years ago

(In reply to Carrie Wang [:carrie] from comment #10)
> Hi Jose, 
> 
> I wonder why do we really need to disable the action buttons here? If users
> tap the button, it will bring up browser (as an inline activity), and if
> there has no internet connection, the browser will display corresponding
> information there, right? 

Well it is actually a window.open (we cannot call the browser activity because otherwise the user will be asked to enter his credentials one more time, as cookies are not shared between apps), but yes you are right, a prompt will be shown asking the user to switch on internet connection ... 

The only caveat I'm seeing while experimenting with this is that the window.open can show old cached content in case there is no connection, but I think we can solve that problem by passing a pseudo-parameter

I think disabling the buttons with no reason or
> providing a confirm window is quite redundant. What do you say? Thanks!

So, we will need to remove the code that disables those buttons. Target is the following sprint

	Jose Manuel Cantera
	Comment 12 • 10 years ago

Carrie,

I've just realized that in Contacts we also disable the 'link contact' option when there is no network connection. In that particular case, we cannot rely on the 'browser settings prompt' as that is an iframe open by the app itself (and not a window.open) managed by the system.  I think that in that particular case we should disable and show a tiny message below to the user saying why that functionality is not currently available.

What do you think?

thanks!

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 13 • 10 years ago

Hi Jose, 

In that case (sync Facebook friends), we shouldn't gray out it as default and if there has no internet connection, we should pop-up a confirm window to inform them that they should switch on the data connection. I think we need to open a new bug on this case. Thanks!

	Francisco Jordano [:arcturus] [:francisco] Assignee
	Comment 14 • 10 years ago

To summarize the actions here:

- Will remove the disable checks and gray areas when not connection in the contact detail.
- Will leave right now grayed out the 'sync Facebook friends' option.
- Will open follow up to check what we do with the 'sync Facebook friends'. Is not clear to me how is going to be the interaction, and we will need UX input for that.

	Francisco Jordano [:arcturus] [:francisco] Assignee
	Comment 15 • 10 years ago

This PR removes disabling fb social buttons when we don't have connection and leaves to the system the fact of moving the user to check connectivity.

There is still some code that checks connectivity for the 'linking' process and the sync with facebook in settings.

As we mention in other bugs, this will require UX input in our side, so will open a follow up to perform that task.

	Jose Manuel Cantera
	Comment 17 • 10 years ago

Comment on attachment 8513655 [details]
Pointer to PR 25635

As I stated in comment #11, we need to avoid showing cached content when there is no network connection. See in the attached screen what can happen in that case

	Francisco Jordano [:arcturus] [:francisco] Assignee
	Comment 18 • 10 years ago

We can open those windows with a cache buster parameter, will try again and ask for review.

	Francisco Jordano [:arcturus] [:francisco] Assignee
	Comment 19 • 10 years ago

Comment on attachment 8513655 [details]
Pointer to PR 25635

Ready for second round.

	Jose Manuel Cantera
	Comment 20 • 10 years ago

Comment on attachment 8513655 [details]
Pointer to PR 25635

I left substantive comments on GH. thanks

	Francisco Jordano [:arcturus] [:francisco] Assignee
	Comment 21 • 10 years ago

Comment on attachment 8513655 [details]
Pointer to PR 25635

PR updated, thanks for the feedback!

	Jose Manuel Cantera
	Comment 22 • 10 years ago

Comment on attachment 8513655 [details]
Pointer to PR 25635

thanks Francisco. good work

	Francisco Jordano [:arcturus] [:francisco] Assignee
	Comment 23 • 10 years ago

Landed:

https://github.com/mozilla-b2g/gaia/commit/4aee256937afe9db2520752650685ba61ce6097d