Closed
Bug 841265
Opened 12 years ago
Closed 12 years ago
test_install_errors.xul calls confirmNextInstall when it shouldn't
Categories
(Core Graveyard :: DOM: Apps, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: bzbarsky, Assigned: myk)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
fabrice
:
review+
myk
:
checkin+
|
Details | Diff | Splinter Review |
From email from Myk:
The problem is that the tests in test_install_errors.xul all call
confirmNextInstall(), which creates a popupshown handler for the install prompt,
before calling mozApps.install(). But most of those mozApps.install() calls no
longer generate install prompts. So when a prompt does appear, there are
multiple handlers waiting to press its button. Only the first of which succeeds.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #713923 -
Flags: review?(fabrice) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 713923 [details] [diff] [review]
patch v1: stop trying to confirm installs that don't prompt
https://hg.mozilla.org/integration/mozilla-inbound/rev/4167e90a7a99
Attachment #713923 -
Flags: checkin+
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•