Closed Bug 862627 Opened 12 years ago Closed 11 years ago

Switch EventListener to WebIDL codegen

Categories

(Core :: DOM: Events, defect)

Product:
Core
Component:
DOM: Events
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Depends on 2 open bugs)

Details

Attachments

(3 files, 4 obsolete files)

Main patch, merged to tip
(deleted), patch
Details | Diff | Splinter Review
Cleanup, merged to tip
(deleted), patch
Details | Diff | Splinter Review
a simple thread agnostic EventTarget object
(deleted), patch
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #835643 +++
Depends on: 862629
Depends on: 874502
Attached patch An additional bit to rip out now-unused code (obsolete) (deleted) — — Splinter Review
Attachment #752315 - Flags: review?(bugs)
Attached patch This should make the new Telephony bits happy (obsolete) (deleted) — — Splinter Review
Attachment #752808 - Flags: review?(bugs)
Attachment #752315 - Flags: review?(bugs) → review+
Attachment #752808 - Flags: review?(bugs) → review+
Blocks: 853893
No longer blocks: 887239
Blocks: 865916
Whiteboard: [Australis:P?][Australis:M?]
Whiteboard: [Australis:P?][Australis:M?]
No longer blocks: 865916
Attached patch Main patch, merged to tip (deleted) — — Splinter Review
Attachment #738285 - Attachment is obsolete: true
Attached patch Cleanup, merged to tip (deleted) — — Splinter Review
Attachment #752315 - Attachment is obsolete: true
Attachment #752808 - Attachment is obsolete: true
Depends on: 914434
Depends on: 914438
Depends on: 914444
Depends on: 914450
Depends on: 914748
No longer blocks: 853893
Depends on: 914985
Depends on: 876277
Depends on: 916995
Try run with all dependencies except bug 840201 fixed: https://tbpl.mozilla.org/?tree=Try&rev=672313bc75e1
Flags: in-testsuite?
Target Milestone: --- → mozilla27
Attached patch a test impl for workers (obsolete) (deleted) — — Splinter Review
Since khuey had some problem using EventTarget on workers, here is a dummy implementation. (Really dummmy - because of returning null GetParentObject, EventReceiver on the main thread may work in a bit unusual way.) Testcase is loading var retval = "FAIL"; var er = new EventReceiver(); er.addEventListener("PASS", function(e) {retval = e.type;}); er.dispatchEvent(new Event("PASS")); retval; in http://mozilla.pettay.fi/workerconsole/
(this one behaves ok on main thread too, and is simpler)
Attachment #809130 - Attachment is obsolete: true
Depends on: 920436
Blocks: 921485
Depends on: 924905
Blocks: 409737
Depends on: 971650
Depends on: 1180525
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: