Closed Bug 841886 Opened 12 years ago Closed 12 years ago

Need GAIA_OPTIMIZE=1 exported for unagi_eng builds

Categories

(Release Engineering :: General, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: mozilla)

Details

Attachments

(1 file)

Vivien recently made some changes to Gaia for perf tests that are exposed to eng builds only when GAIA_OPTIMIZE=1. I've already made this change to builds produced by releases.m.c, but we want to transition away from those builds to the releng ones. In order to do so, the unagi_eng build job will have to be changed to export GAIA_OPTIMIZE=1.
We set GAIA_OPTIMIZE=1 when we flash Gaia on top of these builds, so if I'm not mistaken, this no longer blocks bug 840797?
jgriffin, why is it only for unagi_eng build job and not for unagi build job as well ?
Attached patch as requested (deleted) — Splinter Review
Assignee: nobody → aki
Attachment #724072 - Flags: review?(jgriffin)
for the record, GAIA_OPTIMIZE=1 is only enabled automatically when the build is triggered with "make dogfood" or "make production". Just using "PRODUCTION=1" is not enough.
(In reply to Dave Hunt (:davehunt) from comment #1) > We set GAIA_OPTIMIZE=1 when we flash Gaia on top of these builds, so if I'm > not mistaken, this no longer blocks bug 840797? True.
No longer blocks: 840797
(In reply to Julien Wajsberg [:julienw] from comment #2) > jgriffin, why is it only for unagi_eng build job and not for unagi build job > as well ? It was my understanding that user builds have this enabled by default, and so it isn't explicitly needed there.
Comment on attachment 724072 [details] [diff] [review] as requested Review of attachment 724072 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Aki.
Attachment #724072 - Flags: review?(jgriffin) → review+
Should be fixed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: