Closed
Bug 843272
Opened 12 years ago
Closed 10 years ago
callback interface codegen silently ignores resultNotAddRefed
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: mccr8, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
callback interface Foo {
Foo receiveWeakSelf();
};
Bindings.conf:
'Foo' : {
'resultNotAddRefed': [ 'receiveWeakSelf']
},
The return type of receieveWeakSelf ends up being |already_AddRefed<Foo>|, so it looks like the codegen is ignoring this setting.
I'm guessing it doesn't make any sense for a JS-implemented thing to return something that isn't addrefed, but it would be nice to at least throw an error in the binding generation code to say that this setting is being ignored.
|
Reporter | |
Updated•12 years ago
|
Summary: callback interface codegen silently ignores resultNotAddrefed → callback interface codegen silently ignores resultNotAddRefed
|
Assignee | |
Comment 1•12 years ago
|
||
Sure.
|
|
Assignee | |
Comment 2•12 years ago
|
||
So the tests commented out with this bug number can just be enabled as far as I can tell...
I think we should just throw if callback interface stuff is marked resultNotAddRefed.
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8487644 -
Flags: review?(continuation) → review+
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•