Brian R. Bondy [:bbondy] Reporter
	Description • 12 years ago

This option is currently on by default (toolkit.telemetry.enabled). For privacy reasons, we should expose this through the privacy section of the prefs flyout. It should be really easy to add, it's just a bool pref.

	Jim Mathies [:jimm]
	Comment 1 • 12 years ago

text from yuan:

https://bugzilla.mozilla.org/show_bug.cgi?id=844619#c5

	Allison Naaktgeboren :ally Assignee
	Comment 3 • 11 years ago

the flyout panels are under going some work, let 845468 finish.

	Allison Naaktgeboren :ally Assignee
	Comment 4 • 11 years ago

I need the string you'd like to appear in the pref panel.

The crash reporter one is right above it & it says  "&brandShortName; submits crash reports to help Mozilla make your browser more stable and secure".

	Allison Naaktgeboren :ally Assignee
	Comment 5 • 11 years ago

Yuan says: https://bugzilla.mozilla.org/show_bug.cgi?id=876021 it says "shares usage statistics about Nightly with Mozilla to help us make your browser better" it's a simplified string compared with what we have on desktop.

	Allison Naaktgeboren :ally Assignee
	Comment 6 • 11 years ago

I had question about whether or not I should add an entry in the Flyout js, as we dont need it(I think) but it might be worthwhile for completeness & consistency.

	Tim Abraldes [:TimAbraldes] [:tabraldes]
	Comment 7 • 11 years ago

Comment on attachment 777491 [details] [diff] [review]
v0

Review of attachment 777491 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually apply this patch, but if you say that it does what it says it does I believe you.  Just be sure to run mochitest-metro to make sure we don't break inbound!

::: browser/metro/base/content/flyouts/prefsFlyout.js
@@ +22,5 @@
>      this._elements = {};
>      [
> +      ['prefsFlyout',  'prefs-flyoutpanel'],
> +      ['dntNoPref',    'prefs-dnt-nopref'],
> +      ['telemetryPref','prefs-telemetry'], //TODO do we actually need this? Do we want it any for compeleteness?

We don't need it, but it doesn't hurt.  I don't mind keeping it... or removing it.  Just get rid of the TODO comment :)

::: browser/metro/locales/en-US/chrome/preferences.dtd
@@ +37,5 @@
>  <!ENTITY doNotTrack.options.noPreference                         "Nothing about my tracking preferences">
>  <!ENTITY doNotTrack.options.trackingOkay                         "I want to be tracked">
>  <!ENTITY optionsHeader.reporting.title                           "Crash Reporter">
>  <!ENTITY optionsHeader.reporting.crashes.label                   "&brandShortName; submits crash reports to help Mozilla make your browser more stable and secure">
> +<!ENTITY optionsHeader.telemetry.title                            "Telemetry">      

nit: trailing whitespace

	Allison Naaktgeboren :ally Assignee
	Comment 8 • 11 years ago

I just ran it through mochitest-metro again. No fails.

	Allison Naaktgeboren :ally Assignee
	Comment 9 • 11 years ago

it helps to remember to put your reviewer's name on your commit >.<

	Allison Naaktgeboren :ally Assignee
	Comment 10 • 11 years ago

O Inbound Tree, O Inbound Tree
How steadfast are your branches!
Your boughs are green in hg push's clime
And through oranges of merge time.
O Inbound Tree, O Inbound Tree,
How colorfast are your branches?

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/27377c1b3282

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/27377c1b3282

	Cornel Ionce [:noni] [Hubs QA]
	Comment 13 • 11 years ago

Verified as fixed on latest Nightly (build ID: 20130730030204)

The telemetry pref is added to the options flyout and it's set to "ON" by default.

	Samvedana (:Samvedana)
	Comment 14 • 11 years ago

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc

WFM
Tested on windows 8 using latest nightly for iteration-12. The telemetry pref is added to the options flyout and it's set to "ON" by default.

	Kamil Jozwiak [:kjozwiak]
	Comment 15 • 11 years ago

Went through the following "Story" for iteration #15 (touch device verification) without issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-15-03-03-19-mozilla-central/

- Went through the original story from comment #0 without any issues
- Ensured that "ON" is selected as the default
- Ensured that disabling "toolkit.telemetry.enabled" switched the option to "OFF"
- Ensured that re-enabling ""toolkit.telemetry.enabled"" switched the option of "ON"
- Ensured all of the above test cases worked in both full and filled views

Brian,

Does the "Enable/Disable" option under "about:telemetry" tie into the "toolkit.telemetry.enabled" that's located in about:config? When I disable it from "about:telemetry", should it trickle down to both the about:config and switch the Option selection to "OFF"? Currently, it will leave everything as enabled even though telemetry has been disabled (not sure if these two are related)

	Brian R. Bondy [:bbondy] Reporter
	Comment 16 • 11 years ago

Yep that's definitely a bug and we should triage that for v1. Seems like it's a privacy concern. Please post a new bug for it though. Thanks!

	Kamil Jozwiak [:kjozwiak]
	Comment 17 • 11 years ago

Thanks Brian, created the bug and attached it to this story.