Closed
Bug 847583
Opened 12 years ago
Closed 12 years ago
Paris binding for MessageEvent
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=5235e3e24f03
Not trying to update our MessageEvent to be compatible with the spec.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Assignee: nobody → bugs
Attachment #721652 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #721741 -
Flags: review?(peterv)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 721741 [details] [diff] [review]
patch
Review of attachment 721741 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/events/src/nsDOMMessageEvent.h
@@ +43,5 @@
> + bool* aTriedToWrap)
> + {
> + return mozilla::dom::MessageEventBinding::Wrap(aCx, aScope, this,
> + aTriedToWrap);
> + }
Since you don't need to include the binding header for a dictionary I'd rather put this in the .cpp.
Note: the aTriedToWrap argument was removed in bug 848339.
::: dom/webidl/MessageEvent.webidl
@@ +15,5 @@
> + * Custom data associated with this event.
> + */
> + [GetterThrows]
> + readonly attribute any data;
> +
Trailing whitespace.
@@ +29,5 @@
> + * The last event ID string of the event source, for server-sent DOM events; this
> + * value is the empty string for cross-origin messaging.
> + */
> + readonly attribute DOMString lastEventId;
> +
Trailing whitespace.
Attachment #721741 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•