Closed
Bug 848339
Opened 12 years ago
Closed 12 years ago
Remove the vestigial boolean outparam from nsWrapperCache::WrapObject
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: emk, Assigned: emk)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
After bug 841289, it will no longer be used.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
I'll fold this patch on landing.
Attachment #723057 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•12 years ago
|
||
This patch bitrots very fast...
Attachment #723177 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #723177 -
Attachment is obsolete: true
Attachment #723177 -
Flags: review?(bzbarsky)
Attachment #723201 -
Flags: review?(bzbarsky)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 723057 [details] [diff] [review]
Add more MOZ_OVERRIDEs
r=me
Attachment #723057 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 723201 [details] [diff] [review]
Additional patch
r=me
Attachment #723201 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 723055 [details] [diff] [review]
patch
>+++ b/js/xpconnect/src/XPCConvert.cpp
>- if (!flat && triedToWrap)
>- return false;
I think that needs to be more like:
if (!flat && JS_IsExceptionPending(lccx.GetJSContext()) {
return false;
}
otherwise we might end up trying to create XPConnect wrappers for cases when wrapping threw.
You're going to need to fix SVGFETileElement as well (presumably that change just landed or something).
r=me with those fixed.
When merging, watch out for http://hg.mozilla.org/integration/mozilla-inbound/rev/cbacce36ee58 giving you conflicts. :(
Attachment #723055 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 8•12 years ago
|
||
Flags: in-testsuite-
|
||
Comment 9•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•