Closed Bug 847585 Opened 12 years ago Closed 12 years ago

Paris binding for UIEvent

Categories

(Core :: DOM: Events, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
This includes various classes in content/event/src and SVGZoomEvent
Attached patch uievent (obsolete) (deleted) — Splinter Review
Perhaps other bugs for other UI events. https://tbpl.mozilla.org/?tree=Try&rev=21c05465a3db
Assignee: nobody → bugs
Attached patch up-to-date (deleted) — Splinter Review
Attachment #721914 - Attachment is obsolete: true
Attachment #722834 - Flags: review?(peterv)
Comment on attachment 722834 [details] [diff] [review] up-to-date Review of attachment 722834 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/events/src/nsDOMEvent.h @@ +95,5 @@ > JSContext* aCx, jsval* aVal); > > void InitPresContextData(nsPresContext* aPresContext); > > + bool Init(mozilla::dom::EventTarget* aGlobal); Add a comment that this returns if the event should be trusted. ::: content/events/src/nsDOMUIEvent.h @@ +93,5 @@ > + mozilla::ErrorResult& aRv); > + > + virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope, bool* aTriedToWrap) > + { > + return mozilla::dom::UIEventBinding::Wrap(aCx, aScope, this, aTriedToWrap); Note: the aTriedToWrap argument was removed in bug 848339. ::: dom/webidl/UIEvent.webidl @@ +1,4 @@ > +/* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ > +/* This Source Code Form is subject to the terms of the Mozilla Public > + * License, v. 2.0. If a copy of the MPL was not distributed with this > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. Trailing whitespace.
Attachment #722834 - Flags: review?(peterv) → review+
Summary: Paris bindings for UIEvent and events inheriting UIEvent → Paris binding for UIEvent
Attached patch patch (deleted) — Splinter Review
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
> > + virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope, bool* aTriedToWrap) > > + { > > + return mozilla::dom::UIEventBinding::Wrap(aCx, aScope, this, aTriedToWrap); > > Note: the aTriedToWrap argument was removed in bug 848339. The compiler would have caught this if MOZ_OVERRIDE was used.
compiler caught it even without MOZ_OVERRIDE
Depends on: 856413
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: