Closed
Bug 847756
Opened 12 years ago
Closed 12 years ago
B2G MMS: provide nsIDOMMobileMessageManager.markMessageRead()
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: airpingu, Assigned: airpingu)
References
Details
(Keywords: dev-doc-needed)
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
airpingu
:
review+
airpingu
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #844431 +++ After bug 844431 is done, we can have a |nsIDOMMobileMessageManager| interface to add: DOMRequest markMessageRead(long id, boolean aValue); and then deprecate the following one in the |nsIDOMMobileMessageManager|: nsIDOMMozSmsRequest markMessageRead(in long id, in boolean aValue); This function needs to be compatible with both SMS and MMS.
Comment 1•12 years ago
|
||
this is required to support MMS user stories. Leo+
blocking-b2g: leo? → leo+
Assignee | ||
Comment 2•12 years ago
|
||
Hi Jonas, Need your superreview for the IDL part. Just changing: nsIDOMMozSmsRequest markMessageRead(in long id, in boolean aValue); to nsIDOMDOMRequest markMessageRead(long id, boolean aValue); Thanks! Hi Vicamo, Need your review for the implementation deatils. Thanks!
Attachment #723327 -
Flags: superreview?(jonas)
Attachment #723327 -
Flags: review?(vyang)
Comment on attachment 723327 [details] [diff] [review] Patch Review of attachment 723327 [details] [diff] [review]: ----------------------------------------------------------------- sr=me on the idl changes
Attachment #723327 -
Flags: superreview?(jonas) → superreview+
Updated•12 years ago
|
Attachment #723327 -
Flags: review?(vyang) → review+
Assignee | ||
Comment 5•12 years ago
|
||
r=vicamo sr=sicking a=leo+
Attachment #723327 -
Attachment is obsolete: true
Attachment #725829 -
Flags: superreview+
Attachment #725829 -
Flags: review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcd1fc573133
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dcd1fc573133
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Assignee | ||
Updated•12 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 8•12 years ago
|
||
Assignee | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/28b048ffb7a7
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-firefox20:
--- → wontfix
status-firefox21:
--- → wontfix
status-firefox22:
--- → fixed
Assignee | ||
Updated•12 years ago
|
Whiteboard: [by 3/8] → [NO_UPLIFT]
Assignee | ||
Comment 10•12 years ago
|
||
Added [NO_UPLIFT] per recent commercial RIL compatibility issue. Waiting on further decision to keep the patch in b2g18 or to back it out. ------------------------------ If we really want to back them out, backing the following MMS bugs should be enough to make the commercial RIL compatible: Bug 854422 - B2G MMS: should call .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED after an MMS is retrieved under the RETRIEVAL_MODE_AUTOMATIC mode (a follow-up for bug 845643) Bug 850680 - B2G MMS: broadcast "sms-received" and "sms-sent" system messages Bug 850530 - B2G MMS: Use the same attribute name for delivery (s/state/delivery) like SMS Bug 852911 - B2G MMS: fail to expose correct nsIDOMMozMmsMessage.attachments. Bug 853725 - B2G MMS: fail to read nsIDOMMozMmsMessage.receivers for a received MMS (a follow-up of bug 849741). Bug 853329 - B2G MMS: other Android phones cannot read attachments sent from FFOS Bug 852471 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first) (follow-up fix) Bug 852460 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event (follow-up fix) Bug 849741 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event Bug 847756 - B2G MMS: provide nsIDOMMobileMessageManager.markMessageRead(). Bug 847736 - B2G MMS: provide nsIDOMMobileMessageManager.delete(). Bug 847738 - B2G MMS: provide nsIDOMMobileMessageManager.getMessage(). Bug 844431 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first) Bug 845643 - B2G MMS: Save retrieved MMS into database.
Assignee | ||
Comment 11•12 years ago
|
||
Following the previous comment, some more needs to back out: Bug 792321 - Check max values of MMS parameters in sendRequest. Bug 833291 - B2G SMS & MMS: getMessages it's not working with PhoneNumberJS Bug 844429 - B2G SMS & MMS: move SMS codes into dom/mobilemessage to make it generic for MMS Bug 839436 - B2G MMS: make DB be able to save MMS messages.
Assignee | ||
Comment 12•12 years ago
|
||
Confirming with Michael to see we should back out to Bug 839436 or just Bug 844431 (if we eventually decide to back out). Please see Bug 857632, comment #17.
Assignee | ||
Comment 13•12 years ago
|
||
Per off-line discussion with Michael, we decided not to back out the MMS bugs that have already been in mozilla-b2g18. Removing [NO_UPLIFT] to make the check-in status sync'ed.
Whiteboard: [NO_UPLIFT]
Updated•11 years ago
|
Flags: in-moztrap-
You need to log in
before you can comment on or make changes to this bug.
Description
•