Closed Bug 854422 Opened 12 years ago Closed 12 years ago

B2G MMS: should call .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED after an MMS is retrieved under the RETRIEVAL_MODE_AUTOMATIC mode (a follow-up for bug 845643)

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22
Tracking Status
firefox20 --- wontfix
firefox21 --- wontfix
firefox22 --- fixed
b2g18 + fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: airpingu, Assigned: airpingu)

References

Details

Attachments

(2 files, 2 obsolete files)

Under the RETRIEVAL_MODE_AUTOMATIC mode, after an MMS message is successfully retrieved and saved into the database, we should fire an .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED back to the MMSC, so that the sender can get a delivery report if enabled. The MMS receiving logic is still incomplete due to the above-mentioned reason. Nominating for leo+ because this one blocks bug 849741. Please correct me if I'm wrong. Thanks!
(In reply to Gene Lian [:gene] from comment #0) > Nominating for leo+ because this one blocks bug 849741. ^^^^^^^^^^ Sorry, I mean bug 845643.
Blocks: 845643
No longer blocks: 849741
Summary: B2G MMS: should call .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED after an MMS is retrieved under the RETRIEVAL_MODE_AUTOMATIC mode → B2G MMS: should call .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED after an MMS is retrieved under the RETRIEVAL_MODE_AUTOMATIC mode (a follow-up for bug 845643)
This bug also blocks Bug 850140, because it stops FFOS sending a delivery report back to the sender which used to ask us to return one.
Blocks: 850140
Attached patch Patch (deleted) — Splinter Review
In addition to the fix, some comments are rewritten.
Attachment #729406 - Flags: review?(vyang)
Attachment #729406 - Flags: review?(ctai)
Comment on attachment 729406 [details] [diff] [review] Patch Review of attachment 729406 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. :)
Attachment #729406 - Flags: review?(ctai) → review+
Attachment #729406 - Flags: review?(vyang) → review+
We'll use b2g18-approval to uplift this patch after nominating for it.
blocking-b2g: leo? → ---
tracking-b2g18: --- → ?
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Comment on attachment 729406 [details] [diff] [review] Patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 845643 User impact if declined: without this, we cannot notify the MMS server that the MMS has been successfully retrieved, which means the server would keep sending a deprecated MMS notification to our FFOS. We have to cancel it by ourselves. Testing completed: yes Risk to taking this patch (and alternatives if risky): this is just a follow-up for bug 845643 and touches the MMS codes only. It has no risk to land. Please go ahead to approve this. Thanks! String or UUID changes made by this patch: no
Attachment #729406 - Flags: approval-mozilla-b2g18?
Attachment #729406 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Attached patch [b2g18] Patch (obsolete) (deleted) — Splinter Review
Attached patch [b2g18] Patch (obsolete) (deleted) — Splinter Review
Attachment #730501 - Attachment is obsolete: true
Attached patch [b2g18] Patch (deleted) — Splinter Review
Attachment #730507 - Attachment is obsolete: true
Whiteboard: [NO_UPLIFT]
Added [NO_UPLIFT] per recent commercial RIL compatibility issue. Waiting on further decision to keep the patch in b2g18 or to back it out. ------------------------------ If we really want to back them out, backing the following MMS bugs should be enough to make the commercial RIL compatible: Bug 854422 - B2G MMS: should call .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED after an MMS is retrieved under the RETRIEVAL_MODE_AUTOMATIC mode (a follow-up for bug 845643) Bug 850680 - B2G MMS: broadcast "sms-received" and "sms-sent" system messages Bug 850530 - B2G MMS: Use the same attribute name for delivery (s/state/delivery) like SMS Bug 852911 - B2G MMS: fail to expose correct nsIDOMMozMmsMessage.attachments. Bug 853725 - B2G MMS: fail to read nsIDOMMozMmsMessage.receivers for a received MMS (a follow-up of bug 849741). Bug 853329 - B2G MMS: other Android phones cannot read attachments sent from FFOS Bug 852471 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first) (follow-up fix) Bug 852460 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event (follow-up fix) Bug 849741 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event Bug 847756 - B2G MMS: provide nsIDOMMobileMessageManager.markMessageRead(). Bug 847736 - B2G MMS: provide nsIDOMMobileMessageManager.delete(). Bug 847738 - B2G MMS: provide nsIDOMMobileMessageManager.getMessage(). Bug 844431 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first) Bug 845643 - B2G MMS: Save retrieved MMS into database.
Following the previous comment, some more needs to back out: Bug 792321 - Check max values of MMS parameters in sendRequest. Bug 833291 - B2G SMS & MMS: getMessages it's not working with PhoneNumberJS Bug 844429 - B2G SMS & MMS: move SMS codes into dom/mobilemessage to make it generic for MMS Bug 839436 - B2G MMS: make DB be able to save MMS messages.
Confirming with Michael to see we should back out to Bug 839436 or just Bug 844431 (if we eventually decide to back out). Please see Bug 857632, comment #17.
Per off-line discussion with Michael, we decided not to back out the MMS bugs that have already been in mozilla-b2g18. Removing [NO_UPLIFT] to make the check-in status sync'ed.
Whiteboard: [NO_UPLIFT]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: