Copied from https://github.com/mozilla-b2g/gaia/pull/8414#discussion_r3244594 > It seems we can't run the tests for this file alone because of the mozl10n stuff at the beginning. But the problem is that the whole SMS app is relying on this global variable everywhere so... please file a new bug for getting rid of this variable.

Comment on attachment 728224 [details] Fix for 847975 r=me with the latest nits addressed please squash/rebase and summarize your changes in the commit log (as there are more changes that initially thought).

master: 404b8575baa931acfee4f4169cc703daba037a2b

For posterity, this bug was discovered during work on #846845

Comment on attachment 728224 [details] Fix for 847975 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: no direct user impact but that prevented having real unit tests Testing completed: yes Risk to taking this patch (and alternatives if risky): low, this is in master for some time now and this was heavily tested during review String or UUID changes made by this patch: none Like Bug 854413 this will probably trigger conflicts when uplifting the MMS work and I'd rather uplift this now than wait and investigate those future conflicts when they'll come.

Sent email to clarify the risk/reward, will follow up in bug.

regression: bug 860187

We'll want regression testing around "formatting of displayed dates in the SMS and Threads list), contacts search, and display of the 'no messages' panel when the app is first launched" according to Julien. jsmith - this isn't leo+, so how can we get the necessary QA verification?

I'd stick verifyme for now. If it's a more urgent request to get QA support, I'd do exactly what you just did - needinfo a sheriff and we'll find an owner. Paul - Can you help here?

I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 b430b9af8d0ddb9289622731a3d13c2c80242dfa <RESOLVE MERGE CONFLICTS> git commit

so, that's not the correct hash, the correct hash here is 404b8575baa931acfee4f4169cc703daba037a2b ;)

(it still does not apply but I'm on it)

verify step: 1. launch the message app 2. blank message box displayed 3. send a sms to any number 4. timestamp displayed successfully 5. select panel translated correctly use latest build to verify and the translation correct

v1-train: dc3d8cae86fe11a40e4c717158cde86a4c0b58b6

Following the steps above, after sending an sms and using the checkmark box on the top right (assumed to be the select panel) all text on both screens were correctly translated in to the current system language. Verified for 1.1 and 1.2 1.1 Environmental Variables Device: Leo v1.1 Mozilla RIL Build ID: 20131203041431 Gecko: 617eb9d9bcc2 Gaia: 19c9ff3a46a4389e40253c97b359763243af4531 Platform Version: 18.1 RIL Version: 01.01.00.019.180 Firmware Version: lge_default 1.2 Environmental Variables: Device: Buri v1.2 COM RIL BuildID: 20131204004003 Gaia: 8d762f3376318fd6be390432db750ae4904c9ab6 Gecko: 758f3fb32dda Version: 26.0 Firmware Version: V1.2_20131115