Due to new features in MMS/SMS App need a generic way of creating an 'action-menu', we need a generic way of generating this menu on the fly. This could be part of '/shared' folder in the future.

The goal of this patch is creating a generic way of creating the following type of screen https://bug838000.bugzilla.mozilla.org/attachment.cgi?id=711610

This should block 1.1 then yes?

Yep, due to it's needed for other bugs which are blocking 1.1 as well

Comment on attachment 722321 [details] Pull Request the changes to action_menu.js look good. one final comment in pull request is to move the file to shared/ folder. marking it as r+ from side.

r+

Thanks Rick & Satender for your review!Gracias! ;)

Uplifted commit 34ec6dd4092f8f6455ae7296f1d1a1a445c1164d as: v1-train: 5a59e1ae55c8179adfa8ab85e061f57efdaf1186

This broke install-gaia on v1-train because responsive.css was not checked in together. build/webapp-zip.js:311: Error: Error: Can't add inexistent file to zip : /home/kanru/zone2/mozilla/B2G/gaia/shared/style/responsive.css from: sms.gaiamobile.org

backed out from v1-train: https://github.com/mozilla-b2g/gaia/commit/4073f456f83afb39b8d9d56d462726e3daa94859

Guys, please remember to run tests before committing.

My understanding was that we don't want new SMS features to land on v1-train for now, we want everything to land together. That was the cause of this problem. These bugs should be marked with [NO_UPLIFT] in title.

(In reply to Julien Wajsberg [:julienw] from comment #12) > My understanding was that we don't want new SMS features to land on v1-train > for now, we want everything to land together. That was the cause of this > problem. > > These bugs should be marked with [NO_UPLIFT] in title. This bug is blocking bug 850582, which does not have NO_UPLIFT. Should we still hold off on this uplift?

go for it; I was told that SMS-only features can land.

I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 34ec6dd4092f8f6455ae7296f1d1a1a445c1164d <RESOLVE MERGE CONFLICTS> git commit

taking uplift

v1-train: cdfc1e6472016c5015fce2dcd8a5dc07b97c96cc

Comment on attachment 722321 [details] Pull Request This was landed weeks ago.