Closed Bug 850582 Opened 12 years ago Closed 12 years ago

[SMS] [Generic 'action-menu'] Remove dependencies with SMS App CSS.

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- fixed

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

Attachments

(1 file)

Currently we are using class 'hide' that it's only part of SMS App CSS. On the other hand appending 'n' forms to element only hiding elements it's not the best option ;)
Assignee: nobody → fbsc
Depends on: 848778
Attached file Pull Request (deleted) —
Attachment #724352 - Flags: review?(ssaroha)
Comment on attachment 724352 [details] Pull Request have reviewed and tested the change, looks good. at this point action_menu.js is completely independent of sms code.
Attachment #724352 - Flags: review?(ssaroha) → review+
We need it leo+ to impement the generic action menu necessary for the SMS leo+ US 838000, 838002, 838003, 838004 and 838005
blocking-b2g: --- → leo?
Blocking as this blocks several leo+ bugs
blocking-b2g: leo? → leo+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 0a73439d3a82e3d148eca5685729ad32d33ba744 <RESOLVE MERGE CONFLICTS> git commit
John, for landing this one you should land first 848778 (it's marked in this bug as a dependency) because was backout.
That bug is marked as NO_UPLIFT. I've asked for clarification in the bug to figure out if we should uplift it again.
v1-train: 8a4b7b86648c65ba68ad4d95aa19416f5627ae17
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: