Closed
Bug 849604
Opened 12 years ago
Closed 12 years ago
Defect - Settings list is not populated if opened when program starts
Categories
(Firefox for Metro Graveyard :: Shell, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 22
People
(Reporter: kjozwiak, Assigned: mbrubeck)
References
Details
(Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=2 status=verified)
Attachments
(1 file)
(deleted),
patch
|
bbondy
:
review+
|
Details | Diff | Splinter Review |
If you open the settings charm too fast right after opening the browser, the user does not see the Options, Sync, About, and Help items.
Steps to reproduce the issue:
1. Open Metro Firefox (Do step 2 and 3 really fast as soon as the browser starts)
2. Bring up the charms bar (Windows + C)
3. Click on Settings
Expected result:
See a list of Settings entry points
Actual results:
See only "Permissions" being listed
Updated•12 years ago
|
Whiteboard: p=2
Updated•12 years ago
|
Flags: needinfo?(jbecerra)
QA Contact: jbecerra
Comment 1•12 years ago
|
||
This requires pretty quick movements to trigger. I wasn't able to trigger it at all on my faster machines.
Comment 2•12 years ago
|
||
I tried reproducing this on three machines, one very fast, one mid-fast machine, and an older netbook. I am not able to reproduce this on the newer machines, but I can reproduce this on the netbook. You still have to act fast in order to see the problem but it's more easily reproducible.
Another mitigating factor in addition to how fast you need to click is the fact that if you dismiss the settings and bring them back up everything is back to normal.
Flags: needinfo?(jbecerra)
Assignee | ||
Comment 3•12 years ago
|
||
In addition to slow machines, this will also happen if you launch Metro Firefox by clicking a link to a slow-loading web page.
This trivial patch fixes the problem. I also removed the try/catch block because any exception here is a bug and I'd rather make it easier to discover and fix than silently ignore it.
Comment 4•12 years ago
|
||
Since we have a patch for this could we treat it as a defect of bug 831963 for it4?
Flags: needinfo?(mmucci)
Updated•12 years ago
|
Attachment #724520 -
Flags: review?(netzen) → review+
Comment 5•12 years ago
|
||
mbrubeck: Are there any exceptions thrown for platforms that are not windows?
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Brian R. Bondy [:bbondy] from comment #5)
> mbrubeck: Are there any exceptions thrown for platforms that are not windows?
Ah, good catch... this does throw an exception when using -metrodesktop (even on Windows 8). I'll put the try/catch back in.
We should probably add a real nsIWinMetroUtils implementation for non-Metro platforms that just performs no-ops for all the operations.
Hardware: x86_64 → All
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Comment 7•12 years ago
|
||
Yes, I've included it in Iteration #4 and related it to Bug 831963. Had to reopen it for ScrumBugs. Can be resolved tomorrow.
Status: RESOLVED → REOPENED
Flags: needinfo?(mmucci)
Resolution: FIXED → ---
Whiteboard: p=2 → feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=2
Updated•12 years ago
|
Priority: -- → P1
Summary: Settings list is not populated if opened when program starts → Defect - Settings list is not populated if opened when program starts
Comment 8•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Flags: needinfo?(jbecerra)
Comment 9•12 years ago
|
||
Tested on 2013-03-15 using Nightly built from http://hg.mozilla.org/mozilla-central/rev/0f7261e288f2
- Tested this with several machines and I am not able to reproduce this problem on the faster machines using the steps in comment #0 or launching a site by typing http://... in the Start page
- I tested this on a slow machine and I am still able to at least initially see an empty list of settings, which sometimes eventually gets populated. You can VNC to 10.250.6.86 for an example.
Kamil, how does that look on your end? Is the problem you experienced gone? If it is I will mark this as verified.
Flags: needinfo?(jbecerra)
Reporter | ||
Comment 10•12 years ago
|
||
Juan, went through it at least 30 times (on the same machine) and couldn't reproduce the issue using the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-03-16-16-05-54-mozilla-central/
Looks like the problem has been fixed, can't reproduce it anymore.
Updated•12 years ago
|
Flags: needinfo?(jbecerra)
Comment 11•12 years ago
|
||
Verified by my testing from comment # 9 as well as Kamil's from comment #10.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=2 → feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=2 status=verified
Reporter | ||
Comment 12•11 years ago
|
||
Went through the following "Defect" for iteration #7 testing without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-05-28-03-09-42-mozilla-central/
- Went through Comment 0 without any issues on both a slower machine and a faster machine
- Attempted accessing the "Settings" while a very intensive website was being loaded as suggested by Matt in Comment 3. Instead of the "Settings" not loading and appearing blank, I receive a "Getting info from Nightly.." message, the settings load a few seconds after that without any issues.
Comment 13•11 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6
WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and 3, and got expected result.
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•