For v1.1 features, some apps like email and sms/mms need to pick videos to complete the user stories. email: bug 838008 mms: bug 840044 so we need video picker to support both email and mms to attach video files.

Duplicate of bug 836498?

Bug 836498 is for supporting email user story only, and this one is for video app to support general pick activity for every app that needs pick, like sms/mms, and maybe more in the future.

We need new video select view (in https://bugzilla.mozilla.org/show_bug.cgi?id=838028) for video picker implementation.

Nominating as leo+, as this is blocking a MMS P1 US bug 840044. Adding [NO-UPLIFT] whiteboard, as it can not be uplifted until the complete MMS functionality is ready.

As we learned with images in the gallery, it will be important for the video app to support picks of type "video/*". Requesting apps will use this to mean "I just want a video of any mime type". (And in fact video/* may be the only type we want to support initially to avoid the extra complexity of filtering videos by type)

remove no_uplift as this is does not have a major dependency with MMS

Looks like Steve is busy on MMS bugs, so I am taking back this and start to implement.

Okay, I got a first version of video picker for MMS features to test. Steve, please pull/test this and it should be enough for you get file/blob from video picker via web activity, I am still cleaning up my patch to make sure it can be landed soon, thanks.

Comment on attachment 736165 [details] implement video picker Dale, This patch is ready for review, basically I just added the necessary ui elements and functions to enable the video picker by using the current architecture of video app. And I have left the changes of email for you to test conveniently(MMS is not ready yet), after this patch got r+, I will remove the changes in email so it will not affect email.

UX spec is here: https://www.dropbox.com/s/5giljes7ao9gyrg/email-attachments.pdf

This patch works well. CC other mms developers. Thanks

Code looks good, I have been trying to review but wifi hasnt been working for me, will review as soon as I get it working

Comment on attachment 736165 [details] implement video picker The patch works great, however I dont know if there is a mixup with the UX specs as the visuals dont at all match what is specified in the pdf @ https://bugzilla.mozilla.org/show_bug.cgi?id=849768#c10 and the way they are implemented is quite confusing (the attach button is an icon, and everything autohides when a video previews)

(In reply to Dale Harvey (:daleharvey) from comment #13) > Comment on attachment 736165 [details] > implement video picker > > The patch works great, however I dont know if there is a mixup with the UX > specs as the visuals dont at all match what is specified in the pdf @ > https://bugzilla.mozilla.org/show_bug.cgi?id=849768#c10 and the way they are > implemented is quite confusing (the attach button is an icon, and everything > autohides when a video previews) Dale, Sorry for the misleading comment, please see attachment 737448 [details], you can see the attach button of image picker is an icon, on the top-right corner. I implemented the video picker in the same way so that we can have consistent visual of pickers. I think let's needinfo from Rob and see if he can comment on it. And I agree with you the autohide of video previews should be removed which is the original behaviour of the video previews. Rob, The video picker needs ux input on the visual of the attach button, please see the current image picker or attachment 737448 [details], thanks.

Comment on attachment 736165 [details] implement video picker Ok cool, I should have really checked the gallery implementation. The codes so r+'ing, can wait for robs feedback but I definitely think the autohide should be removed on the way in, Cheers

Okay, sounds good to me, too. I have updated my patch to remove the autohide when picking videos, landing it.

Landed on master: dd039707d0f85e5710287a905ba6d574ff7e51a3

Rob, I am cancelling the needinfo from you cause I have landed this patch, if you think the attach icon is a problem, please file a new bug and we can fix that with another patch, thanks.

Uplifted commit dd039707d0f85e5710287a905ba6d574ff7e51a3 as: v1-train: d7eb6df0e8f2025b18cb2a8657b2ae36aa5f1be6

Covered by test cases in blocking bugs.