Closed Bug 868225 Opened 11 years ago Closed 11 years ago

[MMS][User Story] Video attachment support

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

x86
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed)

RESOLVED FIXED
1.1 CS (11may)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed

People

(Reporter: danheberden, Assigned: gasolin)

References

Details

(Keywords: feature, Whiteboard: [u=commsapps-user c=messaging p=0])

User Story:
As a user, I can attach video (using currently supported MIME types) into an MMS assuming it is within the carrier's limit to send. I can remove this attachment by 

* backspacing over it in the composition area or 
* tap the video thumbnail that represents it and select the remove option from the list of choices (play, replace, remove)
Assignee: nobody → greg
Depends on: 792326, 844431, 845995, 849766, 849768
Keywords: feature
Priority: -- → P2
Target Milestone: --- → 1.1 CS (11may)
P2, not blocking
blocking-b2g: --- → -
Depends on: 870158
Assignee: greg → nobody
For clarity, the following requirements apply to video capture/sharing via MMS:

- For video capture, an MMS Video Limit mode is supported The camera application must support video capture that stops automatically before the file reaches a maximum size to match the handset's maximum MMS attachment file size, being configurable as part of the variant process according to the network provider's network limits.
- Supports H.263 & AMR (3GP) - for both send and receive
- Compose a Message from Media folder Menu: User is able to compose a message via composer from the video folder
- Compose a Message from the image/video capture application: After capturing an image/video with the camera, the user has the option to enter the composer for create an MM, containing the captured image/video.
- Initiate the capture and insert the competed video from inside the message compose application/function
Depends on: 879881
blocking-b2g: - → leo+
Flags: in-moztrap?
in-moztrap+

Moztrap #6761, #6702, #6549, #6766, #7580
Flags: in-moztrap? → in-moztrap+
Assignee: nobody → gasolin
beware, we may need to change "maxFileSize" to "maxFileSizeBytes" see https://bugzilla.mozilla.org/show_bug.cgi?id=879881#c2 and https://bugzilla.mozilla.org/show_bug.cgi?id=879881#c4
Depends on: 853349
I found sometimes the carrier's limit in settings will return 0;

I'd set the default MMS attachment file size to 300*1024 bytes 
(refer to image size limit) if carrier's limit are not set.
patched bug 853349,
Now can get returned filename & blob from camera app
TODOs:

1. parse the video blob (returned from camera) and generate thumbnail, alert when size is larger than expect. (if there's a 3rd party video recorder)

2. in composition area, press thumbnail, select 'view' will play the video

could they be tracked as separate issue?
1. consulted with steve, currently there is a video clip photo instead thumbnail. It is intent to be. Because generate video thumbnail need some additional permission that only video app has.

2. pick video from either video/camera app, long press and select 'view' will crashed the video app.

video app can get correct blob name, size, type as 'video/3gpp'


video app crashed while assign 

dom.player.src = url;


digging to find root cause.
Error log while assign 

dom.player.src = url;



I/Gecko   ( 6002): IPDL protocol error: could not look up PBlob
I/Gecko   ( 6002): IPDL protocol error: Error deserializing 'remoteBlobChild' (PBlob) member of 'RemoteInputStreamParams'
I/Gecko   ( 6002): [Child 6002] ###!!! ABORT: IPDL error [PBlobStreamChild]: "Error deserializing 'remoteBlobChild' (PBlob) member of 'RemoteInputStreamParams'". abort()ing as a result.: file PBlobStreamChild.cpp, line 366
E/Gecko   ( 6002): mozalloc_abort: [Child 6002] ###!!! ABORT: IPDL error [PBlobStreamChild]: "Error deserializing 'remoteBlobChild' (PBlob) member of 'RemoteInputStreamParams'". abort()ing as a result.: file PBlobStreamChild.cpp, line 366
I/Gecko   ( 1307): 
I/Gecko   ( 1307): ###!!! [Parent][AsyncChannel] Error: Channel error: cannot send/recv
Depends on: 887093
talked with dominic since music also crashed while select 'view' to play music blob.

That issue might be depends on bug 887093.
Whiteboard: [u=commsapps-user c=messaging p=0]
test with recent nightly build and confirm bug 887093 fixed.

Since all blocking issues are resolved,mark this bug as fixed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
All leo+ dependencies are status-b2g18: fixed
You need to log in before you can comment on or make changes to this bug.