Jesse Ruderman Reporter
	Description • 11 years ago

###!!! ASSERTION: Should be inner window.: 'win->IsInnerWindow()', file dom/base/nsDOMClassInfo.cpp, line 3599

Assertion failure: win->IsInnerWindow(), at dom/base/nsDOMClassInfo.cpp:1478

	Jesse Ruderman Reporter
	Comment 2 • 11 years ago

Bisection points at http://hg.mozilla.org/mozilla-central/rev/5d58b6d250d5 but I bet that just perturbed the point at which the JS_CHECK_RECURSION fails.

	Daniel Veditz [:dveditz]
	Comment 3 • 11 years ago

Peter: is this assertion an indication of a security problem (usually inner/outer window confusion is) and if so how bad?

	Peter Van der Beken [:peterv]
	Comment 4 • 11 years ago

I'm not sure what happens next, we probably try to wrap the inner in an XPCWrappedNative. But given that we failed to wrap already that might fail too?

Could this be a regression from bug 848339? It seem to me that if nsGlobalWindow::WrapObject fails (at http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCConvert.cpp#841) but doesn't set an exception then we won't return early like we used to, but instead try to construct a slim wrapper.

	Blake Kaplan (:mrbkap) (inactive)
	Comment 5 • 11 years ago

This is almost certainly a regression from bug 848339. Reading through the code, I don't understand why it's OK for WrapObject to return null... It seems like the parameter wasn't as vestigial as previously thought. In general "IsExceptionPending" checks are a sign of trouble.

	Blake Kaplan (:mrbkap) (inactive)
	Comment 6 • 11 years ago

The patch in bug 852436 fixes this testcase as well.

	Al Billings [:abillings - ex-MoCo]
	Comment 7 • 11 years ago

(In reply to Blake Kaplan (:mrbkap) from comment #6)
> The patch in bug 852436 fixes this testcase as well.

Is this fixed then? 

Matt, could you verify this is fixed?

	Matt Wobensmith [:mwobensmith][:matt:]
	Comment 8 • 11 years ago

I see no such assertion in today's nightly m-c. 

Should we close it, or mark it as a dupe of bug 852436?

	Andrew McCreight [:mccr8]
	Comment 9 • 11 years ago

Thanks, Matt!